Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing two parameters for create/update add-on #336

Closed
ghost opened this issue Nov 2, 2017 · 1 comment · Fixed by #338
Closed

Missing two parameters for create/update add-on #336

ghost opened this issue Nov 2, 2017 · 1 comment · Fixed by #338
Assignees
Labels
V2 V2 Client

Comments

@ghost
Copy link

ghost commented Nov 2, 2017

The latest version of the SDK (2.9.0) doesn't match the latest version of the documentation.
recurly-client-php method getWriteableAttributes has the following list of fields that are allowed:
'add_on_code', 'name', 'display_quantity', 'default_quantity', 'unit_amount_in_cents', 'accounting_code', 'tax_code', 'add_on_code', 'name', 'display_quantity', 'default_quantity', 'measured_unit_id', 'usage_type', 'add_on_type', 'revenue_schedule_type'
but this should have the following two also
'optional', 'display_quantity_on_hosted_page'
These two appear in the documentation for "update-an-add-on" and "create-an-add-on"

We had to fork this, push an update and use that fork, in order to move forward with the integration.
It will be very helpful if you can update the SDK with these two parameters also.

Thanks!

@bhelx bhelx self-assigned this Nov 2, 2017
@bhelx
Copy link
Contributor

bhelx commented Nov 3, 2017

@mariusghitoiu Thanks for pointing this out. I'll get a PR out for this as soon as I get the chance.

bhelx added a commit that referenced this issue Dec 11, 2017
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant