Warning in recurly_resource.php @ line 113

[tomarnold2]

Hi, I'm receiving this warning in the recurly-client-php library (version 3.4.0):

"First parameter must either be an object or the name of an existing class in Recurly\RecurlyResource::Recurly{closure}() (line 113 of C:\xampp\apps\myapp\htdocs\vendor\recurly\recurly-client\lib\recurly\recurly_resource.php"

To Reproduce

1. I submit billing info and receive back a valid token
2. I then call $client->previewPurchase($some_data);
3. Everything comes back fully populated, but an $item is coming back from Recurly as null and line 113 isn't expecting it
4. Warning is displayed on the next page load
5. User confirms the purchase and I then call $client->createPurchase($some_data);
6. The subscription is created, webhooks fire, all appears to be fine with the exception of the warning

Expected behavior
No warning message to be given.

Your Environment
PHP Version 7.4.7
Recurly Lib 3.4.0
XAMPP locally (Windows 10)
Chrome version 84.0.4147.89

It's easy enough for me to suppress the error, but I thought you'd want to know (or, if I'm doing something wrong, I'd appreciate a heads-up what that is so I can fix my code).

Thank you,
Tom

P.S. I tried to get the data to format nicely but this editor is munging it. So I'm just pasting the json encoded below.

$some_data
{"currency":"USD","account":{"code":"uid-66","first_name":"Tom","last_name":"Tester","username":"tom@example.com","email":"tom@example.com","tax_exempt":false,"transaction_type":"moto","address":{"street1":"123 Easy Street","street2":"","city":"Seattle","region":"Washington","postal_code":"98101","country":"US"},"billing_info":{"token_id":"sdptyiFxxxxxxxxxxfKQAQ"}},"subscriptions":[{"plan_code":"my_plan_recur_12","quantity":1,"custom_fields":[{"name":"id","value":"54321"},{"name":"id_user","value":"66"},{"name":"sku_nid","value":"121212 \/ PREMIUM_RENEW_012"}]}],"transaction_type":"moto"}

[joannasese]

Hi @tomarnold2. Thanks for reporting. We'll take a look and get back to you.

[douglasmiller]

Hello again, @tomarnold2!

Thanks for bringing this to our attention. This is a legitimate warning and just didn't get noticed in our smoke tests because it was scrolling out of view :/

I've added the appropriate null check in the cast method and the warning is no longer raised. Once the linked PR is merged, this will go out in the next release of the client.