Add option for setting CA cert path #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhelx
force-pushed
the
bundle_optional_ca_cert
branch
2 times, most recently
from
58777bf
to
5b9e127
Compare
|
Adding |
bhelx
force-pushed
the
bundle_optional_ca_cert
branch
4 times, most recently
from
8de5c5e
to
e08c095
Compare
|
Gonna need a rebase after some of the other merges. |
|
Adding |
bhelx
force-pushed
the
bundle_optional_ca_cert
branch
2 times, most recently
from
c3f895a
to
560b0d7
Compare
|
This looks good to go but will need the rebase. |
bhelx
force-pushed
the
bundle_optional_ca_cert
branch
from
560b0d7
to
bc28660
Compare
|
@drewish should i squash as well? |
|
Ah yeah might as well |
bhelx
force-pushed
the
bundle_optional_ca_cert
branch
from
bc28660
to
6fdbce0
Compare
|
Okay, squashed and rebased |
|
+1 |
drewish
added a commit
that referenced
this pull request
Sep 15, 2015
Add option for setting CA cert path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to address #173
@drewish and I have discussed and changed this to accept a path rather than a bundle. I'm going to monitor how well this solves the problem and only reconsider the bundle if enough people need it.
@csmb and I will verify that this work in his bad php installation.
Approvers: @csmb @drewish