-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage Based Billing #227
Usage Based Billing #227
Conversation
public static function init() | ||
{ | ||
Recurly_Addon::$_writeableAttributes = array( | ||
'id','name','display_name','description' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They can set the id?
3cc7af9
to
1a637c3
Compare
protected function getNodeName() { | ||
return 'coupons'; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be getting deleted?
9746223
to
b029d47
Compare
$measured_unit = Recurly_MeasuredUnit::get(123456, $this->client); | ||
|
||
$this->assertInstanceOf('Recurly_MeasuredUnit', $measured_unit); | ||
$this->assertEquals(123456, $measured_unit->id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go ahead and check the name, display_name and description values as well.
<created_at type="date">2016-03-15T23:18:12+00:00</created_at> | ||
<updated_at nil="nil"></updated_at> | ||
<billed_at nil="nil"></billed_at> | ||
<usage_type>PERCENTAGE</usage_type> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that this is getting switched to lowecase you want to go ahead and down case it here too?
So aside from that case change this looks good. We can do that here or in a followup. |
Okay, updated |
<created_at type="date">2016-03-15T23:18:12+00:00</created_at> | ||
<updated_at nil="nil"></updated_at> | ||
<billed_at nil="nil"></billed_at> | ||
<usage_type>PERCENTAGE</usage_type> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry should have called this one out too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, missed that too
+1 |
This is a feature that is not yet enabled on all sites and this PR is still a WIP.
This introduces some new resources and updates to current resources to
support the usage based billing (metered billing) feature.
https://docs.recurly.com/docs/usage-based-billing
Merged Ruby Version: recurly/recurly-client-ruby#237
Testing