Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Pager should implement the Countable interface #282

Merged
merged 2 commits into from
Feb 14, 2017
Merged

The Pager should implement the Countable interface #282

merged 2 commits into from
Feb 14, 2017

Conversation

naderman
Copy link

@naderman naderman commented Nov 1, 2016

The count() class method should be called when using count($subscriptionList).

@naderman
The Pager should implement the Countable interface
ef53605 
The count() class method should be called when using count($subscriptionList).
@drewish
Copy link

drewish commented Jan 6, 2017

Could you add a test to demonstrate this?

@naderman
Copy link
Author

Took a while, but I added assertions to the existing pager tests now, that check count($pager) too.

drewish
drewish approved these changes Feb 14, 2017
View reviewed changes
Copy link

@drewish drewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I commented out the Countable and the specs failed the way you'd expect so this looks good to go. Thanks!

@drewish drewish merged commit eeb0d38 into recurly:master Feb 14, 2017
@bhelx bhelx mentioned this pull request Mar 21, 2017
Merged
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewish drewish drewish approved these changes

Assignees
No one assigned
Labels
V2 V2 Client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@naderman @drewish @bhelx