Adding ability to get Recurly error code from Recurly_Error Exception #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewish
reviewed
Dec 20, 2016
|
|
||
| private $recurlyCode; | ||
|
|
||
| public function __construct($message, $code = 0, Exception $previous = null, $recurlyCode = null) |
There was a problem hiding this comment.
Why not just use the $code parameter? The class is Recurly_Error so it'd seem logical that the code would be a Recurly error code.
There was a problem hiding this comment.
to answer my own question: Exception's code is typed as an int.
drewish
approved these changes
Jan 6, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#290