Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a getType method to all Resources #299

Merged
merged 1 commit into from
Jan 19, 2017
Merged

Adds a getType method to all Resources #299

merged 1 commit into from
Jan 19, 2017

Conversation

bhelx
Copy link
Contributor

@bhelx bhelx commented Jan 19, 2017

Resolves #210
Resolves #245

This adds a method getType on every resource object which returns the xml attribute type. This can currently be found on Adjustments, Transactions, and BillingInfos.

@bhelx
Adds a getType method on Resource
63858d4 
Resolves #210
Resolves #245

This adds a method `getType` on every resource object which returns the
xml attribute `type`. This can currently be found on Adjustments,
Transactions, and BillingInfos.
@bhelx bhelx requested a review from drewish January 19, 2017 20:23
drewish
drewish approved these changes Jan 19, 2017
View reviewed changes
Copy link

@drewish drewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hacky but effective ;) Seriously it seems like the right sized fix for it since it's only used a couple of places.

@drewish drewish merged commit 017bd99 into master Jan 19, 2017
@drewish drewish deleted the parse_xml_type_attributes branch January 19, 2017 20:55
This was referenced Jan 19, 2017
Closed
Closed
@bhelx
Copy link
Contributor Author

bhelx commented Jan 19, 2017

Hacky but effective ;) Seriously it seems like the right sized fix for it since it's only used a couple of places.

I agree, but I wouldn't expect the interface to change with a refactor. I'm afraid a refactor of anything around the xml parsing will need to be scoped out very carefully.

@bhelx bhelx mentioned this pull request Mar 21, 2017
Merged
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewish drewish drewish approved these changes

Assignees
No one assigned
Labels
V2 V2 Client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get the type of an adjustment Innaccessible billing info type
2 participants
@bhelx @drewish