Add nested flag

[g30rg]

it is my first contribution to this repo, but it looks like creating a test in one commit (for the use case i raised bug #325 for) and fix it the follow up commit seems suitable.

all tests pass for me

please let me know whether i need to or can improve this contribution in any way to get this PR accepted

thanks!

[drewish]

The test case is super helpful. Yeah definitely looks like a serialization bug. I'd like to simplify down the test case a little bit to focus on the issue:

  public function testCreateSubscripionWithExistingAccountXml() {
    $this->client->addResponse('GET', "/accounts/abcdef1234567890", 'accounts/create-201.xml');
    $account = Recurly_Account::get('abcdef1234567890', $this->client);

    $subscription = new Recurly_Subscription();
    $subscription->plan_code = 'gold';
    $subscription->quantity = 1;
    $subscription->currency = 'USD';
    $subscription->account = $account;

    $this->assertEquals("<?xml version=\"1.0\"?>\n<subscription><account><account_code>abcdef1234567890</account_code></account><plan_code>gold</plan_code><quantity>1</quantity><currency>USD</currency><subscription_add_ons></subscription_add_ons></subscription>\n", $subscription->xml());
  }

I'm going to go ahead and merge your code then clean up the test and get a release out. Thanks a ton for finding and fixing this.

[g30rg]

i'm glad i was able to help! my bad, the account creation indeed is rather superfluous here. thanks for correcting the test-case and thanks for merging the fix!

[drewish]

2.8.2 is out so let me know if you have any further issues. Thanks again.