Add writeable imported_trial bool to subscription #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewish
reviewed
Sep 15, 2017
lib/recurly/subscription.php
Outdated
| @@ -26,6 +26,7 @@ | |||
| * @property string $add_on_code The code for the Add-On. | |||
| * @property string $usage_percentage If add_on_type = usage and usage_type = percentage, you can set a custom usage_percentage for the subscription add-on. Must be between 0.0000 and 100.0000. | |||
| * @property string $revenue_schedule_type Optional field for setting a revenue schedule type. This will determine how revenue for the associated Subscription Add-On should be recognized. When creating a Subscription Add-On, available schedule types are never, evenly, at_range_start, or at_range_end. If no revenue_schedule_type is set, the Subscription Add-On will inherit the revenue_schedule_type from its Plan Add-On. | |||
| * @property boolean $imported_trial Optionally set true to dennote that this subscription was imported from a trial. | |||
bhelx
force-pushed
the
imported_trial_flag
branch
from
d92be0a
to
9a5b572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an API v2.8 change and is thus going into the
api_version_2_8branch.This allows the merchant to tag a subscription being imported as a trial to ensure Recurly's trial conversion report does not include it as a true trial and instead as an active subscription.