-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Invoice notes on Purchase #332
Conversation
lib/recurly/purchase.php
Outdated
@@ -10,6 +10,9 @@ | |||
* @property string[] $coupon_codes An array of coupon codes to apply to the purchase | |||
* @property Recurly_Subscription[] $subscriptions An array of subscriptions to apply to the purchase | |||
* @property Recurly_GiftCard $gift_card A gift card to apply to the purchase | |||
* @property string $customer_notes Optional notes field. This will default to the Customer Notes text specified on the Invoice Settings page in your Recurly admin. Specify custom notes with this tag to add Customer Notes. Custom notes made on an invoice for a one time charge will not carry over to subsequent invoices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we drop the "Specify custom notes with this tag to add Customer Notes." bit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
lib/recurly/purchase.php
Outdated
@@ -10,6 +10,9 @@ | |||
* @property string[] $coupon_codes An array of coupon codes to apply to the purchase | |||
* @property Recurly_Subscription[] $subscriptions An array of subscriptions to apply to the purchase | |||
* @property Recurly_GiftCard $gift_card A gift card to apply to the purchase | |||
* @property string $customer_notes Optional notes field. This will default to the Customer Notes text specified on the Invoice Settings page in your Recurly admin. Specify custom notes with this tag to add Customer Notes. Custom notes made on an invoice for a one time charge will not carry over to subsequent invoices. | |||
* @property string $terms_and_conditions Optional Terms and Conditions field. This will default to the Terms and Conditions text specified on the Invoice Settings page in your Recurly admin. Specify custom Terms and Conditions with this tag to add or override Terms and Conditions. Custom notes will stay with a subscription on all renewals. | |||
* @property string $vat_reverse_charge_notes Optional VAT Reverse Charge Notes only appear if you have EU VAT enabled or are using your own Avalara AvaTax account and the customer is in the EU, has a VAT number, and is in a different country than your own. This will default to the VAT Reverse Charge Notes text specified on the Tax Settings page in your Recurly admin, unless custom notes were created with the original subscription. Specify custom notes with this tag to add or override VAT Reverse Charge Notes. Custom notes will stay with a subscription on all renewals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could drop all the " Specify custom ... with this tag to add or override ..." language.
f1e28a7
to
4bc6d55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
This is going into the API v2.8 branch. Adds 3 custom invoice notes to the
Purchase
resource.