Custom Invoice notes on Purchase #332
Merged
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewish
reviewed
Oct 4, 2017
lib/recurly/purchase.php
Outdated
| @@ -10,6 +10,9 @@ | |||
| * @property string[] $coupon_codes An array of coupon codes to apply to the purchase | |||
| * @property Recurly_Subscription[] $subscriptions An array of subscriptions to apply to the purchase | |||
| * @property Recurly_GiftCard $gift_card A gift card to apply to the purchase | |||
| * @property string $customer_notes Optional notes field. This will default to the Customer Notes text specified on the Invoice Settings page in your Recurly admin. Specify custom notes with this tag to add Customer Notes. Custom notes made on an invoice for a one time charge will not carry over to subsequent invoices. | |||
There was a problem hiding this comment.
Can we drop the "Specify custom notes with this tag to add Customer Notes." bit?
lib/recurly/purchase.php
Outdated
| @@ -10,6 +10,9 @@ | |||
| * @property string[] $coupon_codes An array of coupon codes to apply to the purchase | |||
| * @property Recurly_Subscription[] $subscriptions An array of subscriptions to apply to the purchase | |||
| * @property Recurly_GiftCard $gift_card A gift card to apply to the purchase | |||
| * @property string $customer_notes Optional notes field. This will default to the Customer Notes text specified on the Invoice Settings page in your Recurly admin. Specify custom notes with this tag to add Customer Notes. Custom notes made on an invoice for a one time charge will not carry over to subsequent invoices. | |||
| * @property string $terms_and_conditions Optional Terms and Conditions field. This will default to the Terms and Conditions text specified on the Invoice Settings page in your Recurly admin. Specify custom Terms and Conditions with this tag to add or override Terms and Conditions. Custom notes will stay with a subscription on all renewals. | |||
| * @property string $vat_reverse_charge_notes Optional VAT Reverse Charge Notes only appear if you have EU VAT enabled or are using your own Avalara AvaTax account and the customer is in the EU, has a VAT number, and is in a different country than your own. This will default to the VAT Reverse Charge Notes text specified on the Tax Settings page in your Recurly admin, unless custom notes were created with the original subscription. Specify custom notes with this tag to add or override VAT Reverse Charge Notes. Custom notes will stay with a subscription on all renewals. | |||
There was a problem hiding this comment.
I think we could drop all the " Specify custom ... with this tag to add or override ..." language.
bhelx
force-pushed
the
purchases_custom_invoice_notes
branch
from
f1e28a7
to
4bc6d55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going into the API v2.8 branch. Adds 3 custom invoice notes to the
Purchaseresource.