Ensure compatibility between Recurly_Resource constructors #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Three sub-classes of Recurly_Resource (Recurly_Plan, Recurly_Addon, and Recurly_AccountBalance) use overload their parents' __construct() methods, but do not accept arguments. This makes it impossible to use mocked Recurly_Client objects during testing when working with these three resources. This commit ensures that these resources can accept $href and $client arguments, passing them through to the parent constructor.
|
@stevegrunwell thanks for taking the time to fix this! I will take a look at it today. |
|
Fantastic, thank you! |
bhelx
approved these changes
Oct 27, 2017
|
@stevegrunwell thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three sub-classes of
Recurly_Resource(Recurly_Plan,Recurly_Addon, andRecurly_AccountBalance) use overload their parents'__construct()methods, but do not accept arguments. This makes it impossible to use mockedRecurly_Clientobjects during testing when working with these three resources, meaning tests can't run without actually calling the Recurly API.This PR ensures that these resources can accept
$hrefand$clientarguments, passing them through to the parent constructor.