API v2.11 Changes #342
Merged
API v2.11 Changes #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bhelx
commented
Apr 2, 2018
bhelx
commented
- Add preferred_locale support on Account.
- Add pause and resume support on Subscription.
- Add multi shipping address support in Purchase.
drewish
reviewed
Apr 3, 2018
| @@ -30,6 +30,8 @@ public function testGetAccount() { | |||
| $this->assertEquals($account->entity_use_code, 'I'); | |||
| $this->assertEquals($account->vat_location_valid, true); | |||
| $this->assertEquals($account->cc_emails, 'cheryl.hines@example.com,richard.lewis@example.com'); | |||
| $this->assertEquals($account->has_paused_subscription, false); | |||
| $this->assertEquals($account->preferred_locale, 'en-US'); | |||
There was a problem hiding this comment.
I think we'd want to test setting preferred_locale in testXml too right?
| @@ -101,7 +103,8 @@ protected function getWriteableAttributes() { | |||
| return array( | |||
| 'currency', 'unit_amount_in_cents', 'quantity', 'description', | |||
| 'accounting_code', 'tax_exempt', 'tax_code', 'start_date', 'end_date', | |||
| 'revenue_schedule_type', 'origin', 'product_code', 'credit_reason_code' | |||
| 'revenue_schedule_type', 'origin', 'product_code', 'credit_reason_code', | |||
| 'shipping_address', 'shipping_address_id' | |||
There was a problem hiding this comment.
Is this change was covered by test? Or is that still on the to do list?
lib/recurly/subscription.php
Outdated
| * - For an active subscription without a pause scheduled already, | ||
| * this will schedule a pause period to begin at the next renewal | ||
| * date for the specified number of billing cycles (remaining_pause_cycles). | ||
| * - When a scheduled pause already exists, this will update the remaining |
There was a problem hiding this comment.
The other two bullet points start with "For a..." so would read a little better if we changed this to "For an active subscription with a pending pause" or something like that.
* Add preferred_locale support on Account. * Add pause and resume support on Subscription. * Add multi shipping address support in Purchase.
drewish
approved these changes
Apr 3, 2018
| @@ -59,7 +59,7 @@ public static function getInvoicePdf($invoiceNumber, $locale = null, $client = n | |||
| * @param string Unique account code | |||
| * @param array additional invoice attributes (see writeableAttributes) | |||
| * @return Recurly_InvoiceCollection collection of invoices on success | |||
| */ | |||
| **/ | |||
There was a problem hiding this comment.
Doesn't really matter but the PHP docs only require the /** you can close with a single */
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.