-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API v2.11 Changes #342
API v2.11 Changes #342
Conversation
bhelx
commented
Apr 2, 2018
- Add preferred_locale support on Account.
- Add pause and resume support on Subscription.
- Add multi shipping address support in Purchase.
@@ -30,6 +30,8 @@ public function testGetAccount() { | |||
$this->assertEquals($account->entity_use_code, 'I'); | |||
$this->assertEquals($account->vat_location_valid, true); | |||
$this->assertEquals($account->cc_emails, 'cheryl.hines@example.com,richard.lewis@example.com'); | |||
$this->assertEquals($account->has_paused_subscription, false); | |||
$this->assertEquals($account->preferred_locale, 'en-US'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd want to test setting preferred_locale
in testXml
too right?
@@ -101,7 +103,8 @@ protected function getWriteableAttributes() { | |||
return array( | |||
'currency', 'unit_amount_in_cents', 'quantity', 'description', | |||
'accounting_code', 'tax_exempt', 'tax_code', 'start_date', 'end_date', | |||
'revenue_schedule_type', 'origin', 'product_code', 'credit_reason_code' | |||
'revenue_schedule_type', 'origin', 'product_code', 'credit_reason_code', | |||
'shipping_address', 'shipping_address_id' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change was covered by test? Or is that still on the to do list?
lib/recurly/subscription.php
Outdated
* - For an active subscription without a pause scheduled already, | ||
* this will schedule a pause period to begin at the next renewal | ||
* date for the specified number of billing cycles (remaining_pause_cycles). | ||
* - When a scheduled pause already exists, this will update the remaining |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other two bullet points start with "For a..." so would read a little better if we changed this to "For an active subscription with a pending pause" or something like that.
* Add preferred_locale support on Account. * Add pause and resume support on Subscription. * Add multi shipping address support in Purchase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looked good with local testing.
@@ -59,7 +59,7 @@ public static function getInvoicePdf($invoiceNumber, $locale = null, $client = n | |||
* @param string Unique account code | |||
* @param array additional invoice attributes (see writeableAttributes) | |||
* @return Recurly_InvoiceCollection collection of invoices on success | |||
*/ | |||
**/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't really matter but the PHP docs only require the /**
you can close with a single */