Bump to 2.10.4 / API version 2.14 #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-junot
force-pushed
the
api_version_2_14
branch
from
ddf07d5
to
dc3f103
Compare
drewish
approved these changes
Aug 21, 2018
Tests/Recurly/Subscription_Test.php
Outdated
| @@ -240,6 +240,11 @@ public function testUpdateNotes() { | |||
|
|
|||
| $notes = array("customer_notes" => "New Customer Notes", "terms_and_condititions" => "New Terms", "vat_reverse_charge_notes" => "New VAT Notes"); | |||
|
|
|||
| // You can also update custom fields through this endpoint | |||
| $cf = $subscription->custom_fields->offsetGet("shasta"); | |||
There was a problem hiding this comment.
Nit pick but I think the preferred style for this would be to just use the array operator:
$subscription->custom_fields["shasta"];
There was a problem hiding this comment.
Yeah, I think that's worth fixing. I'll push up a commit on top.
There was a problem hiding this comment.
I actually didn't know that the bracket syntax worked. TIL, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release will upgrade us to API version 2.14. There are no breaking changes.