Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide a correct recurly code when responding with a 404 #366

Merged
merged 1 commit into from
Sep 10, 2018
Merged

provide a correct recurly code when responding with a 404 #366

merged 1 commit into from
Sep 10, 2018

Conversation

emycakes
Copy link

@emycakes emycakes commented Sep 10, 2018

Attempting to create billing information with a token may return an ambigious 404 for invalid or expired token "token_invalid" and missing recurly account "not_found".

This fixes Reculy_NotFoundError to return a correct value in getRecurlyCode().

@aaron-junot aaron-junot self-assigned this Sep 10, 2018
Copy link

@aaron-junot aaron-junot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mickpaliokas, it looks good to me.

@aaron-junot aaron-junot merged commit e2e7d96 into recurly:master Sep 10, 2018
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants