Remove deprecated Recurly JS module #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's add a reminder in the description here to document this in the next changelog entry. You could also start the changelog entry now. |
aaron-junot
force-pushed
the
remove-js-module
branch
from
c182a29
to
e0f646e
Compare
|
Added an |
|
great! |
|
Should this file also have been removed? https://github.com/recurly/recurly-client-php/blob/master/lib/recurly/util/hmac_hash.php If so, we should remove this line as well recurly-client-php/lib/recurly.php Line 66 in 30d13b1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module is old and deprecated. The counterpart has already been removed from the Ruby and Python client libraries, this just cleans up the PHP library.