Add Capture and Cancel enpoints to go with the Authorize Endpoint #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-junot
reviewed
Dec 17, 2018
aaron-junot
suggested changes
Dec 17, 2018
aaron-junot
reviewed
Dec 17, 2018
aaron-junot
reviewed
Dec 17, 2018
drewish
reviewed
Dec 17, 2018
|
@aaron-suarez I think I fixed everything. Thanks. |
aaron-junot
reviewed
Dec 18, 2018
aaron-junot
approved these changes
Dec 18, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we use your library at work and are moving from charging people immediately to a system where we authorize the amount and then capture the authorization at a later point. Your library is missing the capture and cancel endpoints.
I have tested with these changes in our product and have added in some unit tests similar to the ones that you already have. Hoping you find these changes acceptable.