-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Capture and Cancel enpoints to go with the Authorize Endpoint #386
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your submission! This will be a good addition to the library 😄
@aaron-suarez I think I fixed everything. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for this, looks great! 👍
Hi, we use your library at work and are moving from charging people immediately to a system where we authorize the amount and then capture the authorization at a later point. Your library is missing the capture and cancel endpoints.
I have tested with these changes in our product and have added in some unit tests similar to the ones that you already have. Hoping you find these changes acceptable.