Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing properties to Billing Info #395

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Add missing properties to Billing Info #395

merged 1 commit into from
Jan 17, 2019

Conversation

aaron-junot
Copy link

The properties braintree_payment_nonce and roku_billing_agreement_id were missing from the writable attributes of the billing info class. There were also a few property declarations missing from the PHPDocs so I went ahead and added those in as well.

script:

<?php

try {
  $billing_info = new Recurly_BillingInfo();
  $billing_info->account_code = 'example-1';
  $billing_info->first_name = 'Verena';
  $billing_info->last_name = 'Example';
  $billing_info->braintree_payment_nonce = 'fake-valid-nonce';
  $billing_info->roku_billing_agreement_id = 'a7b07fcc7763598bbf0387856d419047';
  $billing_info->create();

  print "Billing Info: $billing_info";
} catch (Exception $e) {
  print "$e";
}

Copy link
Contributor

@bhelx bhelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bhelx bhelx merged commit ad3a63d into master Jan 17, 2019
@bhelx bhelx deleted the binfo-properties branch January 17, 2019 19:23
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants