Specify which versions of HHVM we should test in travis #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-junot
commented
Feb 12, 2019
aaron-junot
force-pushed
the
specify-hhvm
branch
2 times, most recently
from
f4f8125
to
8b981b2
Compare
bhelx
reviewed
Feb 12, 2019
.travis.yml
Outdated
| sudo: false | ||
| dist: trusty | ||
| install: | ||
| - composer install --dev | ||
| script: vendor/phpunit/phpunit/phpunit Tests | ||
| matrix: | ||
| allow_failures: | ||
| - hhvm |
There was a problem hiding this comment.
You need to specify which version you will allow to fail
aaron-junot
force-pushed
the
specify-hhvm
branch
4 times, most recently
from
3969af1
to
125c5db
Compare
bhelx
reviewed
Feb 12, 2019
README.md
Outdated
| @@ -115,6 +115,8 @@ $ vendor/bin/phpunit | |||
| - [https://support.recurly.com](https://support.recurly.com) | |||
| - [stackoverflow](http://stackoverflow.com/questions/tagged/recurly) | |||
|
|
|||
| Note: Though our library may work on older versions of PHP, we only support [current versions of PHP](http://php.net/supported-versions.php), as well as current LTS versions of [HHVM](https://docs.hhvm.com/hhvm/installation/release-schedule) which support PHP and Composer. | |||
There was a problem hiding this comment.
How something along these lines:
## Supported Versions
We support all ["currently supported versions" of PHP](http://php.net/supported-versions.php).
We also support the LTS versions of [HHVM](https://docs.hhvm.com/hhvm/installation/release-schedule) but only those which support PHP and Composer.
125c5db
to
13d38a4
Compare
aaron-junot
force-pushed
the
specify-hhvm
branch
from
13d38a4
to
d9a41e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HHVM no longer supports Composer or PHP as of version 4.0.0. More information can be found in their blog. https://hhvm.com/blog/2019/02/11/hhvm-4.0.0.html