Fix: pass client to objects in an array #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewish
reviewed
Apr 11, 2019
lib/recurly/base.php
Outdated
| @@ -399,6 +399,9 @@ protected static function __parseXmlToObject($node, &$object) | |||
| // has element children, drop in and continue parsing | |||
| $new_obj = Recurly_Resource::__createNodeObject($node); | |||
There was a problem hiding this comment.
I wonder if it'd be better to just pass client into __createNodeObject as a parameter since most of the time we assign it afterwards. Then we'd avoid needing to check if it's an instance of Recurly_Base.
There was a problem hiding this comment.
Makes sense. I updated the pull request.
glaubinix
force-pushed
the
f/pass-client
branch
from
5d46c0a
to
f1c229a
Compare
aaron-junot
reviewed
Apr 15, 2019
lib/recurly/base.php
Outdated
| @@ -366,7 +364,7 @@ protected static function __parseXmlToObject($node, &$object) | |||
| continue; | |||
| } | |||
|
|
|||
| $new_obj = Recurly_Resource::__createNodeObject($node); | |||
| $new_obj = Recurly_Resource::__createNodeObject($node, $object->_client); | |||
There was a problem hiding this comment.
One reason the tests are failing right now is because in this context, $object can be an array (see line 360) which wouldn't have a _client property.
There was a problem hiding this comment.
Thank you! I addressed the issue and the tests are now passing.
…use the same client
glaubinix
force-pushed
the
f/pass-client
branch
from
f1c229a
to
cc26311
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I encountered an issue where I use a mock client of recurly during test runs where the client does not get passed down to all sub objects.
For instance if I fetch an invoice like this:
if this gets called for an invoice that contains
credit_paymentsthen all the\Recurly_Stubobject on the individual\Recurly_CreditPaymentdo not have theMockClientset as_clientbut instead have the default\RecurlyClientset.