Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing phpdocs #418

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Conversation

glaubinix
Copy link

As discussed in #417 I updated the phpdoc of some of the resource objects. Where available I used the property description from https://dev.recurly.com/docs/.

I am sure there are more missing properties. I focussed on the resources and properties which we use in our application.

@bhelx bhelx self-requested a review August 6, 2019 20:27
Copy link

@peter279k peter279k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good for me.

Resolving conflicting files and it's going to be merged :).

Copy link
Contributor

@joannasese joannasese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joannasese joannasese merged commit f9040a0 into recurly:master Dec 3, 2019
@glaubinix glaubinix deleted the t/phpdocs-updates branch December 3, 2019 18:08
@glaubinix
Copy link
Author

Thank you!

@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
@joannasese joannasese mentioned this pull request Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants