Subscription timeframe changes #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subscription#update, Subscription#preview and Subscription#cancel have changes in the timeframe parameters. Subscription#update and Subscription#preview have been updated to no longer accept the "renewal" value for timeframe. This will continue to work but is deprecated. Instead, merchants will be able to send timeframes of "bill_date" or "term_end". These timeframes are aligned to "current_period_ends_at" and "current_term_ends_at", respectively. Subscription#cancel has been updated to optionally accept the "timeframe" parameter. It accepts values of "bill_date" or "term_end".
joannasese
approved these changes
Oct 21, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscription#update, Subscription#preview and Subscription#cancel
have changes in the timeframe parameters.
Subscription#update and Subscription#preview have been updated to no longer accept the "renewal" value for timeframe. This will
continue to work but is deprecated which means Subscription#updateAtRenewal is also deprecated. Instead, merchants will be able to send a timeframe value of "bill_date" or "term_end".
These timeframes are aligned to "current_period_ends_at" and "current_term_ends_at", respectively.
Subscription#cancel has been updated to optionally accept the "timeframe" parameter. It accepts values of "bill_date" or "term_end".