Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shipping address to Purchase #435

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Add shipping address to Purchase #435

merged 1 commit into from
Oct 18, 2019

Conversation

joannasese
Copy link
Contributor

  • Added 'shipping_address' as a writeable attribute
  • Amended 'Purchase_Test.php' to account for 'shipping_address' as Purchase attribute instead of Account attribute

@joannasese joannasese changed the base branch from master to v2 October 15, 2019 21:03
@joannasese joannasese marked this pull request as ready for review October 15, 2019 23:38
drewish
drewish reviewed Oct 16, 2019
View reviewed changes
Copy link

@drewish drewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference would be to mark the other purchase shipping address fields as deprecated.

lib/recurly/purchase.php Outdated Show resolved Hide resolved
@joannasese joannasese added the V2 V2 Client label Oct 16, 2019
@drewish
Copy link

drewish commented Oct 16, 2019

This looks good from my perspective. I'd just say squash down the commits. I'll let @bhelx give it the final blessing though.

@joannasese joannasese changed the title Add shipping address to purchase Add shipping address to Purchase Oct 17, 2019
@joannasese joannasese force-pushed the add-shipping-address-to-purchase branch from d8602ee to c860ba6 Compare October 17, 2019 22:41
@joannasese
Adding shipping_address to Purchase
5c0fed4 
Move 'shipping_address' to top level of Purchase instead of embedded as an Account attribute. Adjust purchase_test accordingly.

Add 'shipping_address' to docs
@joannasese joannasese force-pushed the add-shipping-address-to-purchase branch from c860ba6 to 5c0fed4 Compare October 17, 2019 22:56
bhelx
bhelx approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor

@bhelx bhelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the eyes @drewish
Squashed and good to go 👍

@bhelx bhelx merged commit 8687d67 into v2 Oct 18, 2019
@bhelx bhelx deleted the add-shipping-address-to-purchase branch October 18, 2019 15:55
@joannasese joannasese mentioned this pull request Oct 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewish drewish drewish left review comments

@bhelx bhelx bhelx approved these changes

Assignees
No one assigned
Labels
V2 V2 Client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joannasese @drewish @bhelx