Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure PHP 7.4 compatibility #449

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Ensure PHP 7.4 compatibility #449

merged 2 commits into from
Dec 10, 2019

Conversation

stevegrunwell
Copy link

PHP 7.4 deprecated the ability to swap the arguments for implode(), making the function signature officially:

 implode ( string $glue , array $pieces ) : string

Without this fix, tests are filled with warnings:

implode(): Passing glue string after array is deprecated. Swap the parameters

This breaks out parts of #444.

PHP 7.4 deprecated the ability to swap the arguments for `implode()`, making the function signature officially:

     implode ( string $glue , array $pieces ) : string

Without this fix, tests are filled with warnings:

> implode(): Passing glue string after array is deprecated. Swap the parameters
Copy link

@drewish drewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, confirmed parameter ordering matches the docs and that all the implodes were updated.

@drewish drewish merged commit 8175b45 into recurly:master Dec 10, 2019
@stevegrunwell stevegrunwell deleted the fix/php7.4-compatibility branch December 10, 2019 21:00
@joannasese joannasese mentioned this pull request Dec 31, 2019
@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants