Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction: update phpdoc #460

Merged
merged 1 commit into from
Feb 21, 2020

Conversation

glaubinix
Copy link

Hello,

I adjusted the properties returned by the list transactions endpoint. Looks like error properties are now sent as a Recurly_TransactionError. I also add some other missing properties.

Note: the transaction_error seems to be incorrect in the documentation as well: https://dev.recurly.com/docs/transaction-object

@joannasese
Copy link
Contributor

@glaubinix taking a look. Will let you know if we have any questions.

@joannasese joannasese self-assigned this Feb 14, 2020
@joannasese joannasese merged commit 9a4f943 into recurly:master Feb 21, 2020
@joannasese
Copy link
Contributor

👍

@joannasese
Copy link
Contributor

Note: the transaction_error seems to be incorrect in the documentation as well: https://dev.recurly.com/docs/transaction-object

@glaubinix are you talking specifically about this page? https://dev.recurly.com/page/transaction-errors

@glaubinix glaubinix deleted the t/transaction-properties branch February 24, 2020 13:25
@glaubinix
Copy link
Author

apologies @joannasese, I was referring to this page: https://dev.recurly.com/docs/transaction-object

@bhelx bhelx added the V2 V2 Client label Mar 3, 2020
@joannasese joannasese mentioned this pull request Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants