Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent overwritten address on new purchase with existing account #470

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Prevent overwritten address on new purchase with existing account #470

merged 2 commits into from
Mar 4, 2020

Conversation

joannasese
Copy link
Contributor

@joannasese joannasese commented Mar 4, 2020 •
edited

  • When new Purchase is created with an existing account, account's address field will not be overwritten with blank values when a new address is not specified.
  • When the existing account's address is changed when the new Purchase is created (rare), the account's address will be updated with the new fields.

@joannasese
Prevent overwritten address on new purchase with existing account
8cd0a23 
- When new Purchase is created with an existing account, account's address field will not be overwritten with blank values when a new address is not specified.
- When the existing account's address is changed with the new Purchase is created (rare), the account's address will be updated with the new fields.
@joannasese joannasese added the V2 V2 Client label Mar 4, 2020
@joannasese joannasese requested review from bhelx March 4, 2020 18:11
@joannasese joannasese force-pushed the dx-1021-existing-account-new-purchase-deletes-address branch from c87d401 to 8cd0a23 Compare March 4, 2020 18:12
bhelx
bhelx approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@bhelx bhelx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bhelx bhelx merged commit ac0836f into v2 Mar 4, 2020
@bhelx bhelx deleted the dx-1021-existing-account-new-purchase-deletes-address branch March 4, 2020 20:52
@joannasese joannasese mentioned this pull request Mar 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhelx bhelx bhelx approved these changes

Assignees
No one assigned
Labels
V2 V2 Client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joannasese @bhelx