Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating client to be compliant with RFC 2616: case-insensitive headers #546

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Updating client to be compliant with RFC 2616: case-insensitive headers #546

merged 1 commit into from
Oct 1, 2020

Conversation

douglasmiller
Copy link
Contributor

According to section 4.2 of RFC 2616:

Each header field consists of a name followed by a colon (":") and the field value. Field names are case-insensitive.

This update will make the client treat headers in a case-insensitive manner.

@douglasmiller
Copy link
Contributor Author 

└[$]› php all_tests.php
all_tests.php
OK
Test cases run: 12/12, Passes: 97, Failures: 0, Exceptions: 0

@joannasese joannasese added the V2 V2 Client label Oct 1, 2020
joannasese
joannasese approved these changes Oct 1, 2020
View reviewed changes
Copy link
Contributor

@joannasese joannasese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joannasese joannasese merged commit 502edc7 into release_2_1 Oct 1, 2020
@joannasese joannasese deleted the 2-1-headers branch October 1, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joannasese joannasese joannasese approved these changes

@chrissrogers chrissrogers Awaiting requested review from chrissrogers

@cainj cainj Awaiting requested review from cainj

Assignees
No one assigned
Labels
bug V2 V2 Client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@douglasmiller @joannasese