Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating client to be compliant with RFC 2616: case-insensitive headers #549

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

douglasmiller
Copy link
Contributor

According to section 4.2 of RFC 2616:

Each header field consists of a name followed by a colon (":") and the field value. Field names are case-insensitive.

This update will make the client treat headers in a case-insensitive manner.

@dbrudner
Copy link

dbrudner commented Oct 1, 2020

ref: refs/heads/2-3-headers
PHP 5.3.29 (cli) (built: Oct  9 2014 00:21:49) 
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.3.0, Copyright (c) 1998-2014 Zend Technologies
PHPUnit 4.2.6 by Sebastian Bergmann.

..............................................................

Time: 1.86 seconds, Memory: 10.00MB

OK (62 tests, 198 assertions)

@dbrudner
Copy link

dbrudner commented Oct 1, 2020

ref: refs/heads/2-3-headers
PHP 5.4.45 (cli) (built: Dec  5 2015 08:26:46) 
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.4.0, Copyright (c) 1998-2014 Zend Technologies
PHPUnit 4.2.6 by Sebastian Bergmann.

..............................................................

Time: 1.05 seconds, Memory: 6.50MB

OK (62 tests, 198 assertions)

@dbrudner
Copy link

dbrudner commented Oct 1, 2020

ref: refs/heads/2-3-headers
PHP 5.5.38 (cli) (built: Aug 10 2016 20:52:31) 
Copyright (c) 1997-2015 The PHP Group
Zend Engine v2.5.0, Copyright (c) 1998-2015 Zend Technologies
PHPUnit 4.2.6 by Sebastian Bergmann.

..............................................................

Time: 1.1 seconds, Memory: 6.75MB

OK (62 tests, 198 assertions)

@dbrudner dbrudner merged commit 70626b7 into release_2_3 Oct 1, 2020
@douglasmiller douglasmiller deleted the 2-3-headers branch September 1, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants