Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating client to be compliant with RFC 2616: case-insensitive headers #553

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

douglasmiller
Copy link
Contributor

According to section 4.2 of RFC 2616:

Each header field consists of a name followed by a colon (":") and the field value. Field names are case-insensitive.

This update will make the client treat headers in a case-insensitive manner.

@joannasese
Copy link
Contributor

ref: refs/heads/2-7-headers
PHP 5.4.45 (cli) (built: Dec 5 2015 08:26:46)
Copyright (c) 1997-2014 The PHP Group
Zend Engine v2.4.0, Copyright (c) 1998-2014 Zend Technologies
PHPUnit 4.2.6 by Sebastian Bergmann.

Configuration read from /app/phpunit.xml.dist

....................................WARNING: API version 1.999 is deprecated and will only be available until 2014-01-01T00:00:00+00:00. Please upgrade the Recurly PHP client.
........................... 63 / 126 ( 50%)
............................................................... 126 / 126 (100%)

Time: 2.72 seconds, Memory: 11.00MB

OK (126 tests, 477 assertions)

Copy link
Contributor

@joannasese joannasese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.4 tests passing. 👍

@joannasese joannasese merged commit eb01e5e into release_2_7 Oct 1, 2020
@joannasese joannasese deleted the 2-7-headers branch October 1, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants