Updating client to be compliant with RFC 2616: case-insensitive headers #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasmiller
commented
Oct 1, 2020
| @@ -82,7 +82,8 @@ public function testFromStub() { | |||
| $relative_url = '/mocks'; | |||
| $this->client->addResponse('GET', $relative_url, 'pager/index-1-200.xml'); | |||
|
|
|||
| $pager = (new Recurly_Stub('mocks', $relative_url, $this->client))->get(); | |||
There was a problem hiding this comment.
This was causing an error in PHP 5.3:
Parse error: syntax error, unexpected T_OBJECT_OPERATOR in /app/Tests/Recurly/Pager_Test.php on line 85
douglasmiller
force-pushed
the
2-8-headers
branch
from
c339dbc
to
cc7fe1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to section 4.2 of RFC 2616:
This update will make the client treat headers in a case-insensitive manner.