Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add item_state and external_sku to phpdocs #568

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Add item_state and external_sku to phpdocs #568

merged 1 commit into from
Nov 17, 2020

Conversation

joannasese
Copy link
Contributor

Because item_state and external_sku are included in the xml response for item-based add-ons, it would be good practice to expose this fields to the programmer.

@joannasese joannasese added the V2 V2 Client label Nov 13, 2020
jguidry-recurly
jguidry-recurly approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@jguidry-recurly jguidry-recurly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jguidry-recurly jguidry-recurly merged commit f4d14d0 into v2 Nov 17, 2020
@joannasese joannasese deleted the add-on-attrs branch November 17, 2020 22:35
@joannasese joannasese mentioned this pull request Nov 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jguidry-recurly jguidry-recurly jguidry-recurly approved these changes

@cainj cainj Awaiting requested review from cainj

@douglasmiller douglasmiller Awaiting requested review from douglasmiller

Assignees
No one assigned
Labels
V2 V2 Client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joannasese @jguidry-recurly