Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postpone subscriptions using the field next_bill_date #610

Merged
merged 2 commits into from
Jun 7, 2021
Merged

Postpone subscriptions using the field next_bill_date #610

merged 2 commits into from
Jun 7, 2021

Conversation

cyberxander90
Copy link
Contributor

According to the doc Postponing Subscriptions should be using the field next_bill_date instead of the deprecated next_renewal_date.

@cyberxander90 cyberxander90 self-assigned this May 24, 2021
@cyberxander90 cyberxander90 marked this pull request as draft May 24, 2021 17:50
joannasese
joannasese reviewed May 24, 2021
View reviewed changes
Copy link
Contributor

@joannasese joannasese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from comment about changelog, this LGTM.

Unrelated to your ticket exactly, but I encountered Function libxml_disable_entity_loader() is deprecated when running unit tests. This should be addressed in a separate ticket.

CHANGELOG.md Outdated
@@ -1,5 +1,14 @@
# Changelog

## [2.12.22](https://github.com/recurly/recurly-client-php/tree/2.12.22) (2021-05-24)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog will generate during the release process, so there's no need to edit it here.

Copy link
Contributor Author

@cyberxander90 cyberxander90 May 24, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. I remove every change I did in the CHANGELOG.md. thks @joannasese

@cyberxander90 cyberxander90 marked this pull request as ready for review May 25, 2021 15:40
joannasese
joannasese approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@joannasese joannasese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@joannasese joannasese merged commit 615c24e into v2 Jun 7, 2021
@joannasese joannasese deleted the postpone-subscription-with-next-bill-date branch June 7, 2021 17:35
recurly-integrations pushed a commit that referenced this pull request Jun 16, 2021
2.12.22
e9fc9e5 
[Full Changelog](2.12.21...2.12.22)

**Merged Pull Requests**

- Postpone subscriptions using the field next_bill_date [#610](#610) ([cyberxander90](https://github.com/cyberxander90))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpgnotgif jpgnotgif jpgnotgif approved these changes

@joannasese joannasese joannasese approved these changes

Assignees

@cyberxander90 cyberxander90

Labels
enhancement V2 V2 Client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cyberxander90 @jpgnotgif @joannasese