-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Postpone subscriptions using the field next_bill_date #610
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from comment about changelog, this LGTM.
Unrelated to your ticket exactly, but I encountered Function libxml_disable_entity_loader() is deprecated
when running unit tests. This should be addressed in a separate ticket.
CHANGELOG.md
Outdated
@@ -1,5 +1,14 @@ | |||
# Changelog | |||
|
|||
## [2.12.22](https://github.com/recurly/recurly-client-php/tree/2.12.22) (2021-05-24) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog will generate during the release process, so there's no need to edit it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool. I remove every change I did in the CHANGELOG.md. thks @joannasese
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
[Full Changelog](2.12.21...2.12.22) **Merged Pull Requests** - Postpone subscriptions using the field next_bill_date [#610](#610) ([cyberxander90](https://github.com/cyberxander90))
According to the doc Postponing Subscriptions should be using the field
next_bill_date
instead of the deprecatednext_renewal_date
.