Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API V2] Client Library and Doc Update - PHP #680 #681

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

paulorbpinho-fullstacklabs

Description:
Created CurrencyPercentageTier and PercentageTier resources.
Created test cases to new resources.
Updated test cases of Addon and Subscription.

@paulorbpinho-fullstacklabs paulorbpinho-fullstacklabs force-pushed the pinho/v2_php_client_updates branch 5 times, most recently from ad6ff42 to 5bbcb35 Compare April 18, 2022 17:28
@paulorbpinho-fullstacklabs paulorbpinho-fullstacklabs force-pushed the pinho/v2_php_client_updates branch 2 times, most recently from 2c91716 to 2dae1ee Compare April 25, 2022 16:47
Description:
Created CurrencyPercentageTier and PercentageTier resources.
Created test cases to new resources.
Updated test cases of Addon and Subscription.
Copy link

@mwlang mwlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks solid to me. The reformatted XML is definitely a readability improvement in the test specs.

@JJDrill
Copy link

JJDrill commented Apr 26, 2022

+1 QA

@JJDrill JJDrill merged commit d2f3783 into v2 Apr 26, 2022
@JJDrill JJDrill deleted the pinho/v2_php_client_updates branch April 26, 2022 15:55
@douglasmiller douglasmiller added the V2 V2 Client label Apr 26, 2022
recurly-integrations pushed a commit that referenced this pull request Jun 17, 2022
[Full Changelog](2.12.24...3.0.0)

**Merged Pull Requests**

- [API V2] Client Library and Doc Update - PHP [#690](#690) ([paulorbpinho-fullstacklabs](https://github.com/paulorbpinho-fullstacklabs))
- [API V2] Client Library and Doc Update - PHP #680 [#681](#681) ([paulorbpinho-fullstacklabs](https://github.com/paulorbpinho-fullstacklabs))
recurly-integrations pushed a commit that referenced this pull request Jun 17, 2022
[Full Changelog](2.12.24...2.12.25)

**Merged Pull Requests**

- V2 add processing_prepayment_balance_in_cents to Recurly_AccountBalance [#691](#691) ([judith](https://github.com/judith))
- [API V2] Client Library and Doc Update - PHP [#690](#690) ([paulorbpinho-fullstacklabs](https://github.com/paulorbpinho-fullstacklabs))
- [API V2] Client Library and Doc Update - PHP #680 [#681](#681) ([paulorbpinho-fullstacklabs](https://github.com/paulorbpinho-fullstacklabs))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants