Add UTF-8 encoding to the DomDocument #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglasmiller
force-pushed
the
utf-8-encoding
branch
from
c031656
to
f498af1
Compare
Smolations
reviewed
Sep 12, 2022
douglasmiller
force-pushed
the
utf-8-encoding
branch
from
f498af1
to
ab08a64
Compare
Smolations
reviewed
Sep 12, 2022
Comment on lines
+108
to
+110
| $doc = new DOMDocument($version); | ||
| $doc->encoding = 'utf-8'; | ||
| return $doc; |
There was a problem hiding this comment.
Seems like we could use this method in all the above files that are creating DOMDocuments? That was the idea of having this thing be a static class, after all. 👍
Smolations
approved these changes
Sep 12, 2022
recurly-integrations
pushed a commit
that referenced
this pull request
Sep 12, 2022
[Full Changelog](2.12.28...2.12.29) **Merged Pull Requests** - Add UTF-8 encoding to the DomDocument [#715](#715) ([douglasmiller](https://github.com/douglasmiller))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the use of UTF-8 characters