Fixing bug with setValues method #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smolations
reviewed
Sep 23, 2022
douglasmiller
force-pushed
the
fix-set-values
branch
from
d351850
to
3ca42e7
Compare
Smolations
approved these changes
Sep 23, 2022
recurly-integrations
pushed a commit
that referenced
this pull request
Sep 23, 2022
[Full Changelog](2.12.29...2.12.30) **Merged Pull Requests** - Fixing bug with setValues method [#717](#717) ([douglasmiller](https://github.com/douglasmiller))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the client was refactored to use the
XmlDoctrait, the behavior of thesetValuesmethod changed. This change resulted in the_unsavedKeysarray not to be populated properly.