-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Custom Fields on Adjustments #740
Conversation
4b430d1
to
616b326
Compare
@@ -58,6 +58,12 @@ Location: https://api.recurly.com/v2/invoices | |||
<created_at nil="nil"></created_at> | |||
<updated_at nil="nil"></updated_at> | |||
<revenue_schedule_type>at_invoice</revenue_schedule_type> | |||
<custom_fields> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as before
@@ -12,6 +12,12 @@ Content-Type: application/xml; charset=utf-8 | |||
<description>$12 Annual Subscription</description> | |||
<accounting_code></accounting_code> | |||
<product_code nil="nil"></product_code> | |||
<custom_fields> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In some cases (it happens for ruby) when the element does not have the type=array then it is not parsed as an array, but as a single element. So I suggest to add the type to comply with the actual response:
<custom_fields> | |
<custom_fields type="array"> |
[Full Changelog](2.12.36...2.12.37) **Merged Pull Requests** - Add Custom Fields on Adjustments [#740](#740) ([ngleiser](https://github.com/ngleiser)) - Added decline code to transaction error [#737](#737) ([arzitney](https://github.com/arzitney))
Add support for custom fields on adjustments