-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation to python 3.10, torch 2.1 #119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Seems to work with python=3.10 torch=2.1.2+cu121
…3.1 was not found in the local cache, Error: Version 3.1 with arch x64 not found
… of pip-compile-multi
…dows) by using pip-compile-cross-platform. NOTE: I had to remove typeguard from dev-3.10.in (but not from pyproject.toml)
…nually) to allow pip to use --find-links to find the wheels and avoid the torch-cluster installation error where it needs torch to be already be installed to build
…-platform crashes
…est workflow" This reverts commit 1a5c37d.
It was a bit of a battle but it is ready to go now. |
bengioe
approved these changes
Feb 22, 2024
Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few updates regarding the installation setup:
tox run
. The.in
files are simply a copy-paste of the dependencies listed in the README. Not ideal since they need to be updated by hand and the .txt files also need to be regenerated by hand everytime we add a new core-dependency inpyproject.toml
, but that doesn't happen very often and the user can still install the repo with a single pip install.