-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QoL improvements and more docs #126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienroyd
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is (unfortunately) fairly massive, but is mostly renaming things, or removing things that aren't needed anymore.
README.md
docs/contributing.md
anddocs/getting_started.md
FlatRewards
intoObjectProperties
, as well as related function namesRewardScalar
into eitherLogScalar
orLinScalar
, as well as changed the function signature of functions accordinglyrng
instances, replaced byget_worker_rng
to remove any confusion around worker seedingdev
should now be acquired viaget_worker_device
None
-proofedcond_info
in models. There should now be a sensible default behavior. Eventually we should properly make sure the code support unconditional taskscfg.git_hash
computational conditional on being in a git repoobj[s]
rather thanmol[s]
terminate
close log files (to avoid issues when a single process runs multiple trials)read_all_results
function insqlite_log.py
. This is probably the fastest way to load log datamypy
issues.