Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated notebook and plotting function #38

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Conversation

nathanlazar
Copy link
Collaborator

What?

  • Updated DepMap comparison notebook to include 19q3
  • I also had to update the BM bars plotting function to get it to show the x-axis labels correctly

Why?

  • We're adding a figure on this to the paper

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nathanlazar nathanlazar requested a review from jamesdj November 2, 2023 17:09
@nathanlazar nathanlazar self-assigned this Nov 2, 2023
@johnurbanik
Copy link
Collaborator

I think it's worth including a small markdown explanation of the differences between the versions with the notebook (even though this is discussed in the paper).

@nathanlazar
Copy link
Collaborator Author

I think it's worth including a small markdown explanation of the differences between the versions with the notebook (even though this is discussed in the paper).

Good point. I added a Markdown cell at the top. Also updated the README, VERSION and deleted a notebook that I replaced before.

@nathanlazar nathanlazar merged commit b655547 into trunk Nov 7, 2023
4 checks passed
@nathanlazar nathanlazar deleted the update_BM_notebook branch November 7, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants