-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add e2e test for Caikit Nlp Client #1075
Add e2e test for Caikit Nlp Client #1075
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Robocop found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/422__caikit_py_client.py
Outdated
Show resolved
Hide resolved
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/gen_client_certs.sh
Outdated
Show resolved
Hide resolved
ods_ci/tests/Tests/400__ods_dashboard/420__model_serving/get_cert.sh
Outdated
Show resolved
Hide resolved
fa7d740
to
300cd5a
Compare
this one cannot be tested on CI yet for some pkg incompatibility. Will align with @aloganat |
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
Signed-off-by: bdattoma <bdattoma@redhat.com>
PR validation
|
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
This is a PR for testing https://github.com/opendatahub-io/caikit-nlp-client against models which are deployed using RHOAI single-model serving stack.
The test code was originally written in a python script in my local copy of the caikit-nlp repo for an ease and faster execution. Now I'm moving it to ods-ci.
UPDATE 21st Dec
Due to an incompatibility between the python libraries caikit-nlp-client and kfp, we cannot add the former in our poetry.toml. We have tried with engineers to relax the caikit-nlp-client dependency requirements but it breaks its functioning.
It means that I had to remove the CLI tests I previously created and replace it (check below section)
kfp
andkfp-kubernetes
kubeflow/pipelines#10307.When it gets merged, we could think of re-integrate the CLI tests
Solution
Notes