Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHOAIENG-18519 - Add KFTO SDK test to downstream automation #2220

Merged
merged 1 commit into from
Feb 11, 2025
Merged

RHOAIENG-18519 - Add KFTO SDK test to downstream automation #2220

merged 1 commit into from
Feb 11, 2025
+54 −0

Conversation

jiripetrlik
Copy link
Contributor

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 10, 2025
View reviewed changes
ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource Fixed Show fixed Hide fixed
ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource Fixed Show fixed Hide fixed
ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource Fixed Show fixed Hide fixed
ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource
@@ -186,6 +208,34 @@
FAIL ${TEST_NAME} failed
END

Run Training Operator KFTO SDK Test
[Documentation] Run Training Operator KFTO SDK Test
[Arguments] ${TEST_NAME}

Check warning

Code scanning / Robocop

{{ var_or_arg }} '{{ variable_name }}' overwrites reserved variable '{{ reserved_variable }}' Warning test

Argument '${TEST_NAME}' overwrites reserved variable '${TEST_NAME}'
...tests/Tests/0600__distributed_workloads/0601__workloads_orchestration/test-run-kft-sdk.robot
Resource ../../../../tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource
Suite Setup Prepare Training Operator SDK Test Suite
Suite Teardown Teardown Training Operator SDK Test Suite

Check warning

Code scanning / Robocop

Invalid number of empty lines between sections ({{ empty_lines }}/{{ allowed_empty_lines }}) Warning test

Invalid number of empty lines between sections (1/2)
sutaakar
sutaakar previously approved these changes Feb 11, 2025
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm label Feb 11, 2025
@openshift-ci openshift-ci bot removed the lgtm label Feb 11, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 11, 2025
View reviewed changes
ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource
@@ -186,6 +198,34 @@
FAIL ${TEST_NAME} failed
END

Run Training Operator KFTO SDK Test
[Documentation] Run Training Operator KFTO SDK Test
[Arguments] ${TEST_NAME}

Check notice

Code scanning / Robocop

{{ set_variable_keyword }} can be replaced with VAR Note test

Set Suite Variable can be replaced with VAR
ods_ci/tests/Resources/Page/DistributedWorkloads/DistributedWorkloads.resource
@@ -186,6 +198,34 @@
FAIL ${TEST_NAME} failed
END

Run Training Operator KFTO SDK Test
[Documentation] Run Training Operator KFTO SDK Test
[Arguments] ${TEST_NAME}

Check warning

Code scanning / Robocop

Don't use suite variables Warning test

Don't use suite variables
@openshift-ci openshift-ci bot added the lgtm label Feb 11, 2025
ChughShilpa
ChughShilpa approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@ChughShilpa ChughShilpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jiri

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 11, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ChughShilpa, jiripetrlik, sutaakar

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiripetrlik jiripetrlik merged commit cb94963 into red-hat-data-services:master Feb 11, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sutaakar sutaakar sutaakar approved these changes

@ChughShilpa ChughShilpa ChughShilpa approved these changes

@Srihari1192 Srihari1192 Awaiting requested review from Srihari1192

Assignees

@sutaakar sutaakar

@ChughShilpa ChughShilpa

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiripetrlik @sutaakar @ChughShilpa