BUG 2139323: return error if last sync time not present #146
Conversation
Sometime the json unmarshal might get success and return empty time stamp. add a check to make sure the time is not zero always. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> (cherry picked from commit 3e1f602)
As per the csiaddon spec last sync time is required parameter in the GetVolumeReplicationInfo if we are failed to parse the description, return not found error message instead of nil which is empty response Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> (cherry picked from commit 8f25edc)
csi-addons/spec#47 defines the error messages for the GetVolumeReplicationInfo RPC call. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com> (cherry picked from commit 3cce629)
|
@Madhu-1: This pull request references Bugzilla bug 2139323, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam. Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assing @red-hat-storage/ceph-csi-contributors |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Madhu-1, Rakshith-R The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@Madhu-1: All pull requests linked via external trackers have merged: Bugzilla bug 2139323 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As per the csiaddon spec, last sync time is a required parameter in the GetVolumeReplicationInfo if we are failed to parse the description, we return an error message instead of nil which is an empty response.
Signed-off-by: madhupr007@gmail.com
Backport of ceph#3489