Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 2246388: fix: Invalid "invalid encryption kms configuration" error #201

Closed
wants to merge 2 commits into from

Conversation

riya-singhal31
Copy link

@riya-singhal31 riya-singhal31 commented Oct 27, 2023

this commit adds the validation for encryption
value as false, and sets the type as none

Backported PR for, ceph#3854

https://bugzilla.redhat.com/show_bug.cgi?id=2246388
Signed-off-by: riya-singhal31 rsinghal@redhat.com

this commit adds the validation for encryption
value as false, and sets the type as none

Signed-off-by: riya-singhal31 <rsinghal@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: riya-singhal31

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Its a good idea label Oct 27, 2023
@riya-singhal31 riya-singhal31 requested review from Madhu-1 and removed request for Madhu-1 October 27, 2023 13:15
Signed-off-by: riya-singhal31 <rsinghal@redhat.com>
@nixpanic
Copy link
Member

@riya-singhal31 can you update the comment to include a link to the upstream PR?

@riya-singhal31
Copy link
Author

@riya-singhal31 can you update the comment to include a link to the upstream PR?

Sure, updated!

@nixpanic
Copy link
Member

Thanks @riya-singhal31! Can you explain why the upstream PR has 4 commits, but this one just 2?

@nixpanic
Copy link
Member

/retitle BUG 2246388: fix: Invalid "invalid encryption kms configuration" error

There is no need to have the full contents of the BZ subject

@openshift-ci openshift-ci bot changed the title Bug 2246388 - [GGS][ODF 4.13.3] MountVolume.MountDevice failed - invalid encryption kms configuration: missing encryption passphrase in secrets BUG 2246388: fix: Invalid "invalid encryption kms configuration" error Oct 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2023

@riya-singhal31: This pull request references Bugzilla bug 2246388, which is valid.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

BUG 2246388: fix: Invalid "invalid encryption kms configuration" error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2023

@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: keesturam.

Note that only red-hat-storage members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@riya-singhal31: This pull request references Bugzilla bug 2246388, which is valid.

2 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @keesturam

In response to this:

BUG 2246388: fix: Invalid "invalid encryption kms configuration" error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nixpanic
Copy link
Member

/close

Changes were included in sync PR #163. ODF-4.14 has the fixes already. If there is a need (and approvals) for including them in release-4.13, these 4 commits need to be cherry-picked:

@openshift-ci openshift-ci bot closed this Oct 27, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2023

@nixpanic: Closed this PR.

In response to this:

/close

Changes were included in sync PR #163. ODF-4.14 has the fixes already. If there is a need (and approvals) for including them in release-4.13, these 4 commits need to be cherry-picked:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 27, 2023

@riya-singhal31: An error was encountered removing this pull request from the external tracker bugs for bug 2246388 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. response code 400 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

BUG 2246388: fix: Invalid "invalid encryption kms configuration" error

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Madhu-1 Madhu-1 deleted the backport branch November 8, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants