Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG 2264002: rbd: log sitestatuses and description #260

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

yati1998
Copy link
Member

This commit logs sitestatues and description in
GetVolumeReplicationInfo RPC call for better
debuging.

Fixes: ceph#4430

Signed-off-by: Yati Padia ypadia@redhat.com
(cherry picked from commit cdc73a7)

This commit logs sitestatues and description in
GetVolumeReplicationInfo RPC call for better
debuging.

Fixes: ceph#4430

Signed-off-by: Yati Padia <ypadia@redhat.com>
(cherry picked from commit cdc73a7)
Copy link

openshift-ci bot commented Feb 20, 2024

@yati1998: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

BUG2264002: rbd: log sitestatuses and description

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Its a good idea label Feb 20, 2024
@Madhu-1
Copy link
Member

Madhu-1 commented Feb 20, 2024

/hold to add another missing commit

@Madhu-1 Madhu-1 changed the title BUG2264002: rbd: log sitestatuses and description BUG 2264002: rbd: log sitestatuses and description Feb 20, 2024
Copy link

openshift-ci bot commented Feb 20, 2024

@yati1998: This pull request references Bugzilla bug 2264002, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.15.0) matches configured target release for branch (ODF 4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (oviner@redhat.com), skipping review request.

In response to this:

BUG 2264002: rbd: log sitestatuses and description

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

currently we are not logging the RequestID
for the replication RPC calls. This PR
adds the replication case to the getReqID
function.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
(cherry picked from commit 4e296bf)
@Madhu-1
Copy link
Member

Madhu-1 commented Feb 20, 2024

/unhold
/lgtm

@openshift-ci openshift-ci bot added lgtm Code looks good and removed do-not-merge/hold labels Feb 20, 2024
Copy link

openshift-ci bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Madhu-1, yati1998

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0ef707f into red-hat-storage:release-4.15 Feb 20, 2024
10 checks passed
Copy link

openshift-ci bot commented Feb 20, 2024

@yati1998: All pull requests linked via external trackers have merged:

Bugzilla bug 2264002 has been moved to the MODIFIED state.

In response to this:

BUG 2264002: rbd: log sitestatuses and description

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nixpanic
Copy link
Member

@yati1998 @Madhu-1 can you please confirm that the changes are available in the devel and release-4.16 branch too?

See https://github.com/red-hat-storage/ceph-csi/tree/devel/redhat#backports for the process that we are required to follow:

  1. change in upstream
  2. backport/sync to downstream devel branch
  3. backport to downstream release-4.16 branch
  4. backport to downstream release-4.15 branch <-- this PR

If this process isn't followed, we may run into a regression if we forget to backport the changes to any of the other branches.

@Madhu-1
Copy link
Member

Madhu-1 commented Feb 20, 2024

@nixpanic yes changes are already in development as part of regular sync and 4.16 will be updated shortly as part of automation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants