Syncing latest changes from upstream devel for ceph-csi #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A function called `setImageOptions()` is expected to set the passed options on the volume. However, the passed options parameter is only filled with the options that should get set on the RBD-image at the time of creation. The naming of the function, and it's parameter is confusing. Rename the function to `constructImageOptions()` and return the ImageOptions to make it easier to understand. Signed-off-by: Niels de Vos <ndevos@ibm.com>
updating external-snapshotter to v8 release. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
all the sidecar log level is not set to 5 by default, without debug logs we cannot understand what is wrong in the tests, this commits sets the log level to 5 for csi pods. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
incase if the pvc is not bound yet, log the pvc events to check what is happening. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
adding a framework to test the volumegroupsnapshot for both cephfs and rbd and added a test case for cephfs. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
Minikube v1.34.0 has been released adding some improvements and bugfixes. See-also: https://github.com/kubernetes/minikube/releases/tag/v1.34.0 Signed-off-by: Niels de Vos <ndevos@ibm.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: df-build-team, Madhu-1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing the latest commits from upstream devel branch