Impl OverprovisionControl using OpenShift's ClusterResourceQuota #1282

synarete · 2021-07-25T14:44:42Z

The following patch-set implements storage-quota (a.k.a, OverprovisionControl) using OpenShift's ClusterResourceQuota mechanism. It enables new section in StorageCluster CRD called OverprovisionControl which allows end-users to define ClusterResourceQuota over OCS storage cluster (either as fixed value or as percentage of raw capacity).

Refs KNIP-1617

synarete · 2021-08-22T13:25:30Z

/retest

…

On Sun, Aug 22, 2021 at 4:16 PM openshift-ci[bot] ***@***.***> wrote: @synarete <https://github.com/synarete>: The following test *failed*, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests: Test name Commit Details Rerun command ci/prow/ocs-operator-bundle-e2e-aws 05b963f <05b963f> link <https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_ocs-operator/1282/pull-ci-openshift-ocs-operator-master-ocs-operator-bundle-e2e-aws/1429411019964289024> /test ocs-operator-bundle-e2e-aws Full PR test history <https://prow.ci.openshift.org/pr-history?org=openshift&repo=ocs-operator&pr=1282>. Your PR dashboard <https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:synarete>. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1282 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5ZRRY5GLLM3JORC4FQTV3T6D2EDANCNFSM5A6TLPZQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

synarete · 2021-08-23T04:38:45Z

/restart

…

On Sun, Aug 22, 2021 at 5:48 PM openshift-ci[bot] ***@***.***> wrote: @synarete <https://github.com/synarete>: The following test *failed*, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests: Test name Commit Details Rerun command ci/prow/ocs-operator-bundle-e2e-aws 05b963f <05b963f> link <https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_ocs-operator/1282/pull-ci-openshift-ocs-operator-master-ocs-operator-bundle-e2e-aws/1429434634835333120> /test ocs-operator-bundle-e2e-aws Full PR test history <https://prow.ci.openshift.org/pr-history?org=openshift&repo=ocs-operator&pr=1282>. Your PR dashboard <https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:synarete>. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1282 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5ZRR3G2HUR4IDXP7XMH73T6EE23ANCNFSM5A6TLPZQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email> .

nbalacha

First pass.

nbalacha · 2021-08-24T12:04:42Z

config/crd/bases/ocs.openshift.io_storageclusters.yaml

+                  PVs overprovisioning relative to the effective usable storage capacity.
+                items:
+                  description: OverprovisionControlSpec defines the allowed overprovisioning
+                    PC consumtion from the underlying cluster. This may be either


Nit: typo: consumption

nbalacha · 2021-08-24T12:05:44Z

config/crd/bases/ocs.openshift.io_storageclusters.yaml

+                    PC consumtion from the underlying cluster. This may be either
+                    as an absolute value or as a percentage from the overall effective
+                    capacity. When defined in terms of percentages, zero value indicates
+                    no over-provisioning.


Does no over-provisioning mean that the limits are not checked or it is limited to 100% of the available capacity?

Following a review by @jarrpa, this need to fixed: either have explicit over-provision or none at all.

nbalacha · 2021-08-24T12:33:07Z

controllers/storagecluster/storagequota.go

+		}
+		requestName := resourceRequestName(opc.StorageClassName)
+		storageQuota := &quotav1.ClusterResourceQuota{
+			TypeMeta:   metav1.TypeMeta{APIVersion: quotav1.SchemeGroupVersion.String(), Kind: clusterResourceQuotaKind},


I don't think the TypeMeta is required here - that is automatically taken care of when you create the quotav1.ClusterResourceQuota.

You are correct! nice.

You are correct. Better to remove it

nbalacha · 2021-08-24T12:36:27Z

controllers/storagecluster/storagequota.go

+				},
+			},
+		}
+		currentQuota, err := r.QuotaV1.ClusterResourceQuotas().Get(context.TODO(), storageQuota.Name, metav1.GetOptions{})


Wouldn't r.Client.Get() work here?

It will not work. OpenShift's ClusterResourceQuota has its own client interface. I do not know why they did it this way, but I tried to follow their conventions. See for example:

https://github.com/openshift/oc/blob/master/pkg/helpers/describe/describer.go#L1749

https://github.com/openshift/oc/blob/master/pkg/cli/create/clusterquota.go#L140

This is infuriating and they should feel bad. 😤

It should work. Controller runtime client works with any runtime.Object provided that correct scheme is added.

@umangachapagain Could you please elaborate on how to add the correct scheme in this case?

Right, a search is basically a get call. For create you will anyway need to specify the namespace for either client, correct?

On second thoughts - In which namespace is the ocs operator creating these ClusterResourceQuotas?
Should it only create the ClusterResourceQuotas for the entries in the StorageCluster and create them in the openshift-storage namespace?
The users can create other ClusterResourceQuotas elsewhere but OCS should not care about those.

This is a very good question, which touches the core issue here: unlike all other resources in OCS, ClusterResourceQuota is not associated with any specific namespace. Think of it as "global" resource, which limits resource consumption from other (labled) namespaces.

global resources exist even without OpenShift and ClusterResourceQuota. controller-runtime client can handle it. We do that for StorageClass.

OK, it looks like it is doable after all (i.e., avoid ClusterResourceQuotas specific interface). Many thanks @nbalacha and @umangachapagain for your inputs

controllers/storagecluster/storagequota.go

nbalacha · 2021-08-24T12:40:30Z

controllers/storagecluster/storagequota.go

+			storageQuota.Spec.DeepCopyInto(&currentQuota.Spec)
+			_, err = r.QuotaV1.ClusterResourceQuotas().Update(context.TODO(), currentQuota, metav1.UpdateOptions{})
+			if err != nil {
+				r.Log.Error(err, "Update ClusterResourceQuota failed")


Please include the name of the ClusterResourceQuota here.

nbalacha · 2021-08-24T12:41:23Z

controllers/storagecluster/storagequota.go

+}
+
+func storageQuotaName(storageClassName string, idx int) string {
+	subKey := storageClassName


If idx is the index in the array this could be problematic if an entry in the middle is deleted. The names of the later entries would change post that.

controllers/storagecluster/storagequota.go

nbalacha · 2021-08-24T12:45:30Z

controllers/storagecluster/storagequota.go

+const storageClassSuffix string = ".storageclass.storage.k8s.io/"
+
+// V1ResourceByStorageClass returns a quota resource name by storage class.
+func V1ResourceByStorageClass(storageClassName string, resourceName corev1.ResourceName) corev1.ResourceName {


How does this work if there are multiple quotas for the same storageClass but different projects.

Personally, I think importing the pkg is better than copying it.

Same. Bringing in additional dependencies is not a concern for me. Having copy-pasted code from another package is dangerous if the source ever changes, and that's a higher priority concern.

nbalacha · 2021-08-24T12:52:49Z

controllers/storagecluster/storagequota.go

+		if hardLimit == nil {
+			continue
+		}
+		requestName := resourceRequestName(opc.StorageClassName)


Should there be a check to see if the storageclass is actually using OCS ceph provisioners?

Following a review by @jarrpa this will be fixed

api/v1/storagecluster_types.go

umangachapagain · 2021-08-25T13:06:13Z

api/v1/storagecluster_types.go

@@ -391,3 +396,13 @@ type ArbiterSpec struct {
 func init() {
 	SchemeBuilder.Register(&StorageCluster{}, &StorageClusterList{})
 }
+
+// OverprovisionControlSpec defines the allowed overprovisioning PC consumtion from the underlying cluster.


What is PC?

Suggested change

// OverprovisionControlSpec defines the allowed overprovisioning PC consumtion from the underlying cluster.

// OverprovisionControlSpec defines the allowed overprovisioning PC consumption from the underlying cluster.

umangachapagain · 2021-08-25T13:07:15Z

api/v1/storagecluster_types.go

@@ -391,3 +396,13 @@ type ArbiterSpec struct {
 func init() {
 	SchemeBuilder.Register(&StorageCluster{}, &StorageClusterList{})
 }
+
+// OverprovisionControlSpec defines the allowed overprovisioning PC consumtion from the underlying cluster.
+// This may be either as an absolute value or as a percentage from the overall effective capacity.


Suggested change

// This may be either as an absolute value or as a percentage from the overall effective capacity.

// This may be an absolute value or a percentage of the overall effective capacity.

umangachapagain · 2021-08-25T13:07:38Z

api/v1/storagecluster_types.go

+
+// OverprovisionControlSpec defines the allowed overprovisioning PC consumtion from the underlying cluster.
+// This may be either as an absolute value or as a percentage from the overall effective capacity.
+// When defined in terms of percentages, zero value indicates no over-provisioning.


Suggested change

// When defined in terms of percentages, zero value indicates no over-provisioning.

// When defined in percentage, zero value indicates no over-provisioning.

umangachapagain · 2021-08-25T13:10:41Z

controllers/storagecluster/storagequota.go

+		requestName := resourceRequestName(opc.StorageClassName)
+		storageQuota := &quotav1.ClusterResourceQuota{
+			TypeMeta:   metav1.TypeMeta{APIVersion: quotav1.SchemeGroupVersion.String(), Kind: clusterResourceQuotaKind},
+			ObjectMeta: metav1.ObjectMeta{Name: storageQuotaName(opc.StorageClassName, idx)},


we have a separate file for all name generating functions. Move storageQuotaName there and follow similar naming.

umangachapagain · 2021-08-25T13:19:06Z

controllers/storagecluster/storagequota.go

+// https://github.com/kubernetes/kubernetes/blob/v1.21.2/pkg/quota/v1/evaluator/core/persistent_volume_claims.go#L63
+//
+// Avoids importing "k8s.io/kubernetes/pkg/quota/v1/evaluator/core" and its chain of dependencies
+// TODO: Ask Jose A.Rivera if he prefers import


Suggested change

// TODO: Ask Jose A.Rivera if he prefers import

@jarrpa What do you prefer?

umangachapagain · 2021-08-25T13:20:53Z

controllers/storagecluster/storagequota.go

+// storageClassSuffix is the suffix to the qualified portion of storage class resource name.
+// For example, if you want to quota storage by storage class, you would have a declaration
+// that follows <storage-class>.storageclass.storage.k8s.io/<resource>.
+const storageClassSuffix string = ".storageclass.storage.k8s.io/"


Should probably move this and all name generation functions below to generate.go?

umangachapagain · 2021-08-25T13:23:24Z

controllers/storagecluster/storagequota_test.go

+func createFakeStorageClusterWithQuotaReconciler(t *testing.T, obj ...runtime.Object) *StorageClusterReconciler {
+	scheme := createFakeSchemeWithQuota(t)
+	client := fake.NewClientBuilder().WithScheme(scheme).WithRuntimeObjects(obj...).Build()
+
+	return &StorageClusterReconciler{
+		Client:        client,
+		QuotaV1:       fakequota.NewSimpleClientset().QuotaV1(),
+		Scheme:        scheme,
+		serverVersion: &k8sVersion.Info{},
+		Log:           logf.Log.WithName("storagequota_test"),
+		platform:      &Platform{platform: configv1.NonePlatformType},
+	}
+}
+
+func createFakeSchemeWithQuota(t *testing.T) *runtime.Scheme {
+	scheme := createFakeScheme(t)
+	err := quotav1.AddToScheme(scheme)
+	if err != nil {
+		assert.Fail(t, "failed to add quotav1 scheme")
+	}
+	return scheme
+}


Try reusing already available utilities rather than creating more.

umangachapagain · 2021-08-25T13:24:42Z

metrics/internal/collectors/storagequota_test.go

+		TypeMeta: metav1.TypeMeta{
+			APIVersion: "quota.openshift.io",
+			Kind:       "ClusterResourceQuota",
+		},


Suggested change

TypeMeta: metav1.TypeMeta{

APIVersion: "quota.openshift.io",

Kind: "ClusterResourceQuota",

},

umangachapagain · 2021-08-25T13:24:59Z

metrics/internal/collectors/storagequota_test.go

+		TypeMeta: metav1.TypeMeta{
+			APIVersion: "quota.openshift.io",
+			Kind:       "ClusterResourceQuota",
+		},


Suggested change

TypeMeta: metav1.TypeMeta{

APIVersion: "quota.openshift.io",

Kind: "ClusterResourceQuota",

},

jarrpa · 2021-08-25T12:52:45Z

controllers/storagecluster/storagequota.go

+				},
+			},
+		}
+		currentQuota, err := r.QuotaV1.ClusterResourceQuotas().Get(context.TODO(), storageQuota.Name, metav1.GetOptions{})


This is infuriating and they should feel bad. 😤

controllers/storagecluster/storagequota.go

jarrpa · 2021-08-25T13:05:16Z

controllers/storagecluster/storagequota.go

+const storageClassSuffix string = ".storageclass.storage.k8s.io/"
+
+// V1ResourceByStorageClass returns a quota resource name by storage class.
+func V1ResourceByStorageClass(storageClassName string, resourceName corev1.ResourceName) corev1.ResourceName {


Same. Bringing in additional dependencies is not a concern for me. Having copy-pasted code from another package is dangerous if the source ever changes, and that's a higher priority concern.

controllers/storagecluster/uninstall_reconciler.go

jarrpa · 2021-08-25T13:50:32Z

controllers/storagecluster/storagequota_test.go

+func createFakeStorageClusterWithQuotaReconciler(t *testing.T, obj ...runtime.Object) *StorageClusterReconciler {
+	scheme := createFakeSchemeWithQuota(t)
+	client := fake.NewClientBuilder().WithScheme(scheme).WithRuntimeObjects(obj...).Build()
+
+	return &StorageClusterReconciler{
+		Client:        client,
+		QuotaV1:       fakequota.NewSimpleClientset().QuotaV1(),
+		Scheme:        scheme,
+		serverVersion: &k8sVersion.Info{},
+		Log:           logf.Log.WithName("storagequota_test"),
+		platform:      &Platform{platform: configv1.NonePlatformType},
+	}
+}
+
+func createFakeSchemeWithQuota(t *testing.T) *runtime.Scheme {
+	scheme := createFakeScheme(t)
+	err := quotav1.AddToScheme(scheme)
+	if err != nil {
+		assert.Fail(t, "failed to add quotav1 scheme")
+	}
+	return scheme
+}


Don't do this, we want to avoid this kind of duplication if possible. See the following commit for an example: 837ae4b

jarrpa · 2021-08-25T13:53:28Z

controllers/storagecluster/storagequota_test.go

+	var obj ocsStorageQuota
+	err := obj.ensureCreated(r, sc)
+	assert.NoError(t, err)
+	assert.Equal(t, len(listStorageQuotas(t, r)), 2)
+
+	sc.Spec.OverprovisionControl[1].Percentage = 60
+	err = obj.ensureCreated(r, sc)
+	assert.NoError(t, err)
+	assert.Equal(t, len(listStorageQuotas(t, r)), 2)
+
+	sc.Spec.OverprovisionControl[0].Capacity = &testQuantity1T
+	err = obj.ensureCreated(r, sc)
+	assert.NoError(t, err)
+	assert.Equal(t, len(listStorageQuotas(t, r)), 2)


For things like this, try to follow the test-cases format we're using elsewhere: https://github.com/openshift/ocs-operator/blob/master/controllers/storagecluster/storagecluster_controller_test.go#L248-L304 This helps reduce duplication of actual test code so extending them becomes much easier.

In this case, you'll want to supply the different OPCs as test variables. Also, be sure to call Created and Deleted for every test iteration so we have clean test environments.

jarrpa · 2021-08-25T13:54:16Z

controllers/storagecluster/storagequota_test.go

+var testQuantity1T = resource.MustParse("1Ti")
+var testQuantity2T = resource.MustParse("2Ti")
+var testStorageClusterWithOverprovision = &api.StorageCluster{


s/test/mock, just out of convention.

jarrpa · 2021-08-25T14:03:22Z

controllers/storagecluster/storagequota_test.go

+
+var testQuantity1T = resource.MustParse("1Ti")
+var testQuantity2T = resource.MustParse("2Ti")
+var testStorageClusterWithOverprovision = &api.StorageCluster{


Rather than defining a new StorageCluster, define a valid StorageDeviceSets list with appropriate OPCs. Since you already have a function for the DeepCopy, you could do a DeepCopy of the existing mock StorageCluster and then DeepCopy the SDSs/OPCs into that.

jarrpa · 2021-08-25T14:04:36Z

controllers/storagecluster/storagequota_test.go

+	var obj ocsStorageQuota
+	err := obj.ensureCreated(r, sc)
+	assert.NoError(t, err)
+	assert.Equal(t, len(listStorageQuotas(t, r)), 2)


Try not to hardcode any values like this. You should be able to determine the expected count from the spec you're providing.

jarrpa · 2021-08-25T14:06:33Z

controllers/storagecluster/storagequota_test.go

+func TestStorageQuotaEnsureCreatedDeleted(t *testing.T) {
+	r := createFakeStorageClusterWithQuotaReconciler(t)
+	sc := createStorageClusterWithOverprovision()
+
+	var obj ocsStorageQuota
+	err := obj.ensureCreated(r, sc)
+	assert.NoError(t, err)
+	assert.Equal(t, len(listStorageQuotas(t, r)), 2)
+
+	err = obj.ensureDeleted(r, sc)
+	assert.NoError(t, err)
+	assert.Equal(t, len(listStorageQuotas(t, r)), 0)
+}


This is a bit of a tricky situation for all parts of ocs-operator. But generally, you should not need a separate test function for testing create and delete. The test cases for the overall feature already contain the ensureCreated() and ensureDeleted() calls, so as long as you have proper error reporting we'll see what went wrong.

jarrpa · 2021-08-25T15:59:47Z

A few other top-level change requests:

Reorganize the commits roughly in the following fashion:
1. count+replica split
2. OPC implementation+API
3. OPC unit tests
4. OPC code generation
5. OPC vendor changes
6. OPC metics implementation
7. OPC metrics vendor changes
Try and format the error messages with the following rules (general k8s conventions):
- lowercase letter at beginning of string
- General format of: error with resource %s: %v where %v is the err

umangachapagain · 2021-08-26T06:22:43Z

A few other top-level change requests:
* Try and format the error messages with the following rules (general k8s conventions):
  * lowercase letter at beginning of string
  * General format of: `error with resource %s: %v` where `%v` is the `err`

This is for returning errors.
If you are logging errors, use sentence case. And provide more contextual information.

nbalacha · 2021-08-26T10:04:01Z

controllers/storagecluster/storagecluster_controller.go

@@ -72,6 +74,7 @@ type ImageMap struct {
 //nolint
 type StorageClusterReconciler struct {
 	client.Client
+	QuotaV1        quotav1.QuotaV1Interface


Please rename to QuotaClient. QuotaV1 is usually the format for the API itself

nbalacha · 2021-08-26T10:04:24Z

controllers/storagecluster/storagecluster_controller.go

@@ -6,6 +6,8 @@ import (

 	"github.com/go-logr/logr"
 	nbv1 "github.com/noobaa/noobaa-operator/v2/pkg/apis/noobaa/v1alpha1"
+
+	quotav1 "github.com/openshift/client-go/quota/clientset/versioned/typed/quota/v1"


Please import as quotaclient or similar

When calculating the usable capacity of a cluster, other modules will need to take into account the same logic of count and replica. Avoid cope duplication by exporting this logic via dedicated function. Signed-off-by: Shachar Sharon <ssharon@redhat.com>

The core logic of creation ClusterResourceQuota for OCS storage-cluster. For each OverprovisionControl entry in StorageCluster, define a corresponding ClusterResourceQuota object using OpenShift's quota-client mechanism. The actual value is one of two cases: - Explicit hard-limit - Derived as percentage from the cluster's raw capacity Enable ocsStorageQuota as part of resource-managers reconcile loop. Enable apiGroup 'quota.openshift.io' with resources clusterresourcequotas. Signed-off-by: Shachar Sharon <ssharon@redhat.com>

synarete · 2021-08-27T06:33:03Z

/restart

…

On Fri, Aug 27, 2021 at 9:23 AM openshift-ci[bot] ***@***.***> wrote: @synarete <https://github.com/synarete>: The following test *failed*, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests: Test name Commit Details Rerun command ci/prow/ocs-operator-ci b0c40e8 <b0c40e8> link <https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_ocs-operator/1282/pull-ci-openshift-ocs-operator-master-ocs-operator-ci/1431139330654474240> /test ocs-operator-ci Full PR test history <https://prow.ci.openshift.org/pr-history?org=openshift&repo=ocs-operator&pr=1282>. Your PR dashboard <https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:synarete>. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1282 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5ZRR4SX7SPBYK5FWDTBPDT64VNZANCNFSM5A6TLPZQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

Using ClusterResourceQuota fake client to test overprovisionControl functionality (Create/Update/Delete). Signed-off-by: Shachar Sharon <ssharon@redhat.com>

Signed-off-by: Shachar Sharon <ssharon@redhat.com>

Export storage clusterresourcequota HARD/USED metrics via Prometheus exporter. For-each ClusterResourceQuota storage entry, export a pair on hard-limit/used-count metrics. Signed-off-by: Shachar Sharon <ssharon@redhat.com>

Signed-off-by: Shachar Sharon <ssharon@redhat.com>

synarete · 2021-08-27T11:21:44Z

/restart

…

On Fri, Aug 27, 2021 at 1:06 PM openshift-ci[bot] ***@***.***> wrote: @synarete <https://github.com/synarete>: The following test *failed*, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests: Test name Commit Details Rerun command ci/prow/ocs-operator-bundle-e2e-aws 1938be9 <1938be9> link <https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_ocs-operator/1282/pull-ci-openshift-ocs-operator-master-ocs-operator-bundle-e2e-aws/1431163184533737472> /test ocs-operator-bundle-e2e-aws Full PR test history <https://prow.ci.openshift.org/pr-history?org=openshift&repo=ocs-operator&pr=1282>. Your PR dashboard <https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:synarete>. Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1282 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5ZRR3JUMOIYM6XWIZRCMLT65PRJANCNFSM5A6TLPZQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

jarrpa

/lgtm

jarrpa · 2021-08-27T19:28:48Z

/retest-required

openshift-ci · 2021-08-27T19:28:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jarrpa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jarrpa]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot requested review from jarrpa and obnoxxx July 25, 2021 14:44

synarete force-pushed the storagequota branch from 06c0f84 to 91307e9 Compare August 3, 2021 07:12

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2021

synarete force-pushed the storagequota branch from 91307e9 to b9b801e Compare August 5, 2021 08:06

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2021

synarete force-pushed the storagequota branch 2 times, most recently from e1d5ead to 5c4768b Compare August 17, 2021 07:19

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2021

synarete force-pushed the storagequota branch from 5c4768b to c3615ec Compare August 19, 2021 09:44

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 19, 2021

synarete force-pushed the storagequota branch from c3615ec to 05b963f Compare August 22, 2021 11:51

anmolsachan mentioned this pull request Aug 24, 2021

add ClusterResourceQuota prometheus alert for overprovisioning #1311

Merged

synarete force-pushed the storagequota branch from 05b963f to e792c30 Compare August 24, 2021 09:13

nbalacha requested changes Aug 24, 2021

View reviewed changes

umangachapagain added this to the OCS 4.9 milestone Aug 25, 2021

umangachapagain requested changes Aug 25, 2021

View reviewed changes

jarrpa requested changes Aug 25, 2021

View reviewed changes

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2021

nbalacha reviewed Aug 26, 2021

View reviewed changes

jarrpa added mvp Required for the next minimum viable product. priority/0-critical Highest priority. Must be actively worked on as someone's top priority right now. labels Aug 26, 2021

synarete force-pushed the storagequota branch from e792c30 to 12e2736 Compare August 26, 2021 14:22

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2021

jarrpa self-assigned this Aug 26, 2021

jarrpa assigned synarete Aug 26, 2021

synarete added 2 commits August 27, 2021 09:00

synarete force-pushed the storagequota branch from 12e2736 to b0c40e8 Compare August 27, 2021 06:19

synarete added 5 commits August 27, 2021 10:46

storagecluster: overprovision unit tests

610be43

Using ClusterResourceQuota fake client to test overprovisionControl functionality (Create/Update/Delete). Signed-off-by: Shachar Sharon <ssharon@redhat.com>

make gen-latest-csv after overprovision changes

c48c1a0

Signed-off-by: Shachar Sharon <ssharon@redhat.com>

vendor: overprovision depends code

f1ad367

Signed-off-by: Shachar Sharon <ssharon@redhat.com>

metrics: export storagequota metrics via prometheus

0419564

Export storage clusterresourcequota HARD/USED metrics via Prometheus exporter. For-each ClusterResourceQuota storage entry, export a pair on hard-limit/used-count metrics. Signed-off-by: Shachar Sharon <ssharon@redhat.com>

vendor: overprovision metrics exporter depends code

1938be9

Signed-off-by: Shachar Sharon <ssharon@redhat.com>

synarete force-pushed the storagequota branch from b0c40e8 to 1938be9 Compare August 27, 2021 07:53

jarrpa approved these changes Aug 27, 2021

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2021

openshift-merge-robot merged commit 39a6f7e into red-hat-storage:master Aug 27, 2021

	// OverprovisionControlSpec defines the allowed overprovisioning PC consumtion from the underlying cluster.
	// OverprovisionControlSpec defines the allowed overprovisioning PC consumption from the underlying cluster.

	// This may be either as an absolute value or as a percentage from the overall effective capacity.
	// This may be an absolute value or a percentage of the overall effective capacity.

	// When defined in terms of percentages, zero value indicates no over-provisioning.
	// When defined in percentage, zero value indicates no over-provisioning.

Impl OverprovisionControl using OpenShift's ClusterResourceQuota #1282

Impl OverprovisionControl using OpenShift's ClusterResourceQuota #1282

Conversation

synarete commented Jul 25, 2021 • edited by openshift-ci bot Loading

synarete commented Aug 22, 2021 via email

synarete commented Aug 23, 2021 via email

nbalacha left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

synarete Aug 25, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jarrpa commented Aug 25, 2021

umangachapagain commented Aug 26, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

synarete commented Aug 27, 2021 via email

synarete commented Aug 27, 2021 via email

jarrpa left a comment

Choose a reason for hiding this comment

jarrpa commented Aug 27, 2021

openshift-ci bot commented Aug 27, 2021

synarete commented Jul 25, 2021 •

edited by openshift-ci bot

Loading

synarete Aug 25, 2021 •

edited

Loading