Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default virtualization storage class annotation #2213

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Add default virtualization storage class annotation #2213

merged 1 commit into from
Oct 16, 2023

Conversation

akalenyu
Copy link
Contributor

@akalenyu akalenyu commented Oct 15, 2023 •
edited
Loading

This signals to kubevirt that requests not explicitly specifying any storage class should use this one.
kubevirt/containerized-data-importer#2913

@akalenyu
Add default virtualization storage class annotation
7f28435 
This signals to kubevirt that requests not explicitly specifying any storage class
should use this one.

Signed-off-by: Alex Kalenyuk <akalenyu@redhat.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 15, 2023

Hi @akalenyu. Thanks for your PR.

I'm waiting for a red-hat-storage member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@akalenyu
Copy link
Contributor Author

akalenyu commented Oct 15, 2023 •
edited
Loading

/cc @Madhu-1 @nixpanic

@Madhu-1
Copy link
Member

Madhu-1 commented Oct 16, 2023

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 16, 2023
Madhu-1
Madhu-1 reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@Madhu-1 Madhu-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change LGTM but i dont have much context about it, so letting @nixpanic approve it.

@nixpanic
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@nixpanic
Copy link
Member

/unassign
/assign malayparida2000

@openshift-ci openshift-ci bot assigned malayparida2000 and unassigned nixpanic Oct 16, 2023
@malayparida2000
Copy link
Contributor

/retest

@malayparida2000
Copy link
Contributor

/test ocs-operator-bundle-e2e-aws

1 similar comment
@malayparida2000
Copy link
Contributor

/test ocs-operator-bundle-e2e-aws

@agarwal-mudit
Copy link
Member

/retest

@agarwal-mudit
Copy link
Member

/cherry-pick release-4.14

@openshift-cherrypick-robot
Copy link

@agarwal-mudit: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agarwal-mudit
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, akalenyu, nixpanic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2023
@openshift-ci openshift-ci bot merged commit 70f2156 into red-hat-storage:main Oct 16, 2023
11 checks passed
@openshift-cherrypick-robot
Copy link

@agarwal-mudit: new pull request created: #2216

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 16, 2023
Merged
@openshift-ci openshift-ci bot mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Madhu-1 left review comments

Assignees

@malayparida2000 malayparida2000

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akalenyu @Madhu-1 @nixpanic @malayparida2000 @agarwal-mudit @openshift-cherrypick-robot