Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds failOnWarning flag to support failing validation on Warning … #18

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

gad0lin
Copy link
Contributor

@gad0lin gad0lin commented Jun 9, 2021

Adds failOnWarning flag to support failing validation on Warning severity

<plugin>
                <groupId>de.redsix</groupId>
                <artifactId>dmn-check-maven-plugin</artifactId>
                <version>1.2.0-SNAPSHOT</version>
                <configuration>
                    <failOnWarning>true</failOnWarning>
                </configuration>
                <executions>
                    <execution>
                        <phase>verify</phase>
                        <goals>
                            <goal>check-dmn</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>

…erity

    <plugin>
                    <groupId>de.redsix</groupId>
                    <artifactId>dmn-check-maven-plugin</artifactId>
                    <version>1.2.0-SNAPSHOT</version>
                    <configuration>
                        <failOnWarning>true</failOnWarning>
                    </configuration>
                    <executions>
                        <execution>
                            <phase>verify</phase>
                            <goals>
                                <goal>check-dmn</goal>
                            </goals>
                        </execution>
                    </executions>
                </plugin>
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #18 (f1bb6ee) into master (618b596) will decrease coverage by 0.22%.
The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #18      +/-   ##
============================================
- Coverage     84.34%   84.11%   -0.23%     
- Complexity      428      429       +1     
============================================
  Files            45       45              
  Lines           894      900       +6     
  Branches         45       46       +1     
============================================
+ Hits            754      757       +3     
- Misses          104      106       +2     
- Partials         36       37       +1     
Impacted Files Coverage Δ
.../src/main/java/de/redsix/dmncheck/CheckerMain.java 55.55% <0.00%> (-1.59%) ⬇️
...ain/java/de/redsix/dmncheck/plugin/PluginBase.java 66.66% <66.66%> (-0.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 618b596...f1bb6ee. Read the comment docs.

@pSub
Copy link
Member

pSub commented Jun 11, 2021

Looks good, thank you!

@pSub pSub merged commit 8394cf6 into red6:master Jun 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants