Fix jumpy behavior when paired with self expanding decorated tasks #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the frontend's DecoratedTasks components will sometimes expand themselves on hover we need to expose some way of letting them inform the CellMeasurer Cache and the List component what changes have occurred. Otherwise the expanded tasks will bleed into the task beneath it.
We want to do a deep equals check on the
list.rows
content before updating the cache/list since the frontend almost always passes in a newlists
prop whenever any interaction takes place on the board. (Perhaps due to backbone-redux not using immutability-helpers? RVK usesreact-addons-update
to similar effect so I doubt the issue is internal) Otherwise all the task lists will clear their caches and resize themselves when any task is moved. It would be nice to fix this in the future however since this is a deep equals check on a user-determined array of task objects.When doing this deep equals check we want to keep track of the index of the changed rows and not recompute row heights for rows higher than the ones that were changed. Else the list will resize and jump unexpectedly (similar to this bug)