Merge pull request #2651 from redbox-mint/bugfix/targetstep-not-appli…

…ed-oncreate "targetStep" not applied during record creation
redbox-mint · Dec 3, 2024 · 082ad87 · 082ad87
2 parents 4a1ddbe + 6856c1f
commit 082ad87
Showing 1 changed file with 12 additions and 12 deletions.
diff --git a/typescript/api/services/RecordsService.ts b/typescript/api/services/RecordsService.ts
@@ -246,19 +246,19 @@ export module Services {
 
           // update the metadata ...
           createResponse = await this.updateMeta(brand, oid, record, user, false, false);
-
-          if (createResponse && _.isFunction(createResponse.isSuccessful) && createResponse.isSuccessful()) {
-            sails.log.verbose(`RecordsService - create - before ajaxOk`);
-
-            if (targetStep) {
-              let wfStep = await WorkflowStepsService.get(recordType.name, targetStep).toPromise();
-              this.setWorkflowStepRelatedMetadata(record, wfStep);
-            }
-
-          } else {
-            sails.log.error('RecordsService - create - Failed to save record: ' + JSON.stringify(createResponse));
-            return createResponse;
+        }
+        // FIX: targetStep not getting applied when creating new records. 
+        // Moved the target step outside of the datastream attachments update block
+        if (createResponse && _.isFunction(createResponse.isSuccessful) && createResponse.isSuccessful()) {
+          sails.log.verbose(`RecordsService - create - before ajaxOk`);
+
+          if (targetStep) {
+            let wfStep = await WorkflowStepsService.get(recordType.name, targetStep).toPromise();
+            this.setWorkflowStepRelatedMetadata(record, wfStep);
           }
+        } else {
+          sails.log.error('RecordsService - create - Failed to save record: ' + JSON.stringify(createResponse));
+          return createResponse;
         }
 
         if (triggerPostSaveTriggers) {