Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Emails for pending access were not being lower cased #1667

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

andrewbrazzatti
Copy link
Contributor

Email Addresses are being made lowercase when stored in the user database but this was not happening for the email addresses stored in the pending access arrays on the record (i.e. editPending and viewPending) so potentially records were not being matched on login for these users.

This fix sets the pending email addresses to lower case

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f082f20) 42.86% compared to head (5e75a9a) 43.17%.

Additional details and impacted files
@@               Coverage Diff               @@
##           support/2.x    #1667      +/-   ##
===============================================
+ Coverage        42.86%   43.17%   +0.31%     
===============================================
  Files              132      132              
  Lines             5942     5945       +3     
  Branches           826      827       +1     
===============================================
+ Hits              2547     2567      +20     
+ Misses            3070     3051      -19     
- Partials           325      327       +2     
Files Coverage Δ
typescript/api/services/RDMPService.ts 24.03% <66.66%> (+0.35%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewbrazzatti andrewbrazzatti merged commit a23773c into support/2.x Oct 23, 2023
@andrewbrazzatti andrewbrazzatti deleted the hotfix/lower-case-pending-emails branch October 23, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant